Repository navigation
Conversation
I also have this problem. Why does it do that?! |
Because it's retarded. Making a clever fix like you suggest is how I would normally solve the problem myself, however with production code it is best not to change the behavior of existing functions. |
|
I have signed the CLA! |
|
Thanks for contributing! This package is deprecated and we're archiving this repo, so we're closing all open issues and PRs. Please use shopify-app-php instead, and open new issues there. More context: Rethinking support for PHP/Python packages |
WHY are these changes introduced?
I couldn't add a webhook, because it insists on making all HttpDelivery webhooks a path of Context::$HOST_NAME (which was myshop.myshopify.com), and I wanted a webhook on my server.
I also couldn't delete a webhook.
WHAT is this pull request doing?
Added a new enum to Webhooks::Registry::register
which doesn't try and get smart with the provided url
To allow deletion of webhooks with the maximum code re-use, I modified Webhooks::Registry::register to equate an empty
$pathwith a request to delete the webhook.Type of change
Checklist
There's documentation?