tecnix: fix target result values getting GC'd mid-call - #51
Open
joshheinrichs-shopify wants to merge 1 commit into
Open
tecnix: fix target result values getting GC'd mid-call#51joshheinrichs-shopify wants to merge 1 commit into
joshheinrichs-shopify wants to merge 1 commit into
Conversation
prim_tecnixTargets and the dependency path kept the only references to
result Values in plain std::vector buffers, which Boehm GC does not
scan. Recycled cells crashed at the ValueStorage::finish pdThunk
unreachable ("Unexpected condition in ... finish(...)") or silently
corrupted results. Root them in ValueVector / traceable_allocator
storage. Regression test: tests/functional/tecnix/gc.sh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prim_tecnixTargets and the dependency path kept the only references to result Values in plain std::vector buffers, which Boehm GC does not scan. Recycled cells crashed at the ValueStorage::finish pdThunk unreachable ("Unexpected condition in ... finish(...)") or silently corrupted results. Root them in ValueVector / traceable_allocator storage. Regression test: tests/functional/tecnix/gc.sh.