Repository navigation
[fix] preserve isolation of minified require bundles - #40
Merged
mwasiluk merged 1 commit intoNov 4, 2026
Merged
Conversation
@rollup/plugin-terser defaults to toplevel: true for the cjs output. The minified module bundle then starts with top-level vars that hold the require wrapper's cache and factories, so a second minified module bundle in the same scope overwrote them (Maximum call stack size exceeded, r is not a function). Terser now runs with toplevel: false; plain and standalone files are unchanged. bundle-isolation.test.js (module targets) checks the added globals, the exports and cache after another require bundle is loaded, the require chain before and after the bundle, MODULE_NOT_FOUND and lazy evaluation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rollup/plugin-terser defaults to toplevel: true for the cjs output. The minified module bundle then starts with top-level vars that hold the require wrapper's cache and factories, so a second minified module bundle in the same scope overwrote them (Maximum call stack size exceeded, r is not a function). Terser now runs with toplevel: false; plain and standalone files are unchanged.
bundle-isolation.test.js (module targets) checks the added globals, the exports and cache after another require bundle is loaded, the require chain before and after the bundle, MODULE_NOT_FOUND and lazy evaluation.