Repository navigation
Conversation
UpdateData only wrote the 1:90 Coded Character Set dataset when a value's encoding was the Encoding.UTF8 instance. Cloning an IPTC value clones its encoding, so a profile from a cloned image, or a value set with a caller's own UTF8Encoding, was written without the declaration and other readers fell back to Latin-1 for non-ASCII text. The encoding is now matched by code page.
4 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
IptcProfile.UpdateDatawrites the 1:90 Coded Character Set dataset (ESC % G, UTF-8) before the application records when a value is UTF-8. It checked this with a reference comparison,value.Encoding == Encoding.UTF8.IptcValue.DeepCloneclones the encoding, so every value in a cloned profile failed the check. A common case isimage.Clone(...)followed by a save. A value set with the caller's ownUTF8Encodinginstance failed the check too. Those profiles were written without the character set declaration, so other applications read non-ASCII text such as "ESPAÑA" as Latin-1 ("ESPAÃ'A").The check now compares the encoding's code page with UTF-8. The
UpdateDatadocumentation now says when the 1:90 dataset is written, including that ASCII-only UTF-8 values also get it.Tests
New tests in
IptcProfileTests:new UTF8Encoding(false)writes the 1:90 dataset.The Release build passes for net10.0. All Metadata, EXIF, IPTC and ICC tests pass (1417 tests).
Fixes #3238