Add chart validation CI + helm-unittest suite (CE-272)#10
Conversation
Adds .github/workflows/validate.yaml: on PRs touching helm/**, runs helm lint, helm template | kubeconform -strict (default + every example values file), and helm unittest. Gates the release.yaml publish, which previously fired on a Chart.yaml version bump with no pre-publish validation. Adds helm/tests/ unittest suites asserting pass-through plumbing: scheduling fields (topologySpreadConstraints, affinity, tolerations, nodeSelector) and upstream-token env wiring. CE-272. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/validate.yaml: on PRs touchinghelm/**, runshelm lint,helm template | kubeconform -strict(default render + every example values file), andhelm unittest. This gates therelease.yamlpublish, which previously fired on aChart.yamlversion bump with no pre-publish validation.helm/tests/unittest suites asserting the chart's pass-through plumbing:scheduling_test.yaml—topologySpreadConstraints,affinity,tolerations,nodeSelector(absent by default, rendered verbatim when set).upstream_tokens_test.yaml— a path route'supstreamTokenproduces the rightsecretKeyRefenv var.Stacked on #8
This branches off the CE-271 (topologySpread) branch because the suite asserts the
topologySpreadConstraintsbehavior added there. Merge #8 first; GitHub will retarget this PR tomainautomatically. (Base is set to the CE-271 branch so the diff here shows only the CI/test additions.)Validation (local)
helm unittest helm— 5/5 pass across 2 suiteshelm lintcleanhelm template | kubeconform -strict(k8s 1.30) — default + corporate/forward-proxy/remote-first examples all validNotes
release.yaml;permissions: contents: read.kubeconformandhelm-unittestpinned by version (v0.8.0,v1.1.1).Linear: CE-272
Made with Cursor