You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, thank you! It looks like core::error::Error was stabilized on 5 September, 2024 which is less than one year ago (by a few days). It is also incompatible with the version of Rust nightly that we use for our internal projects (20 April, 2024). As a result, even though the way you've written it would only affect no_std users, it will be some time before we merge this.
Also, before we merge this, we should change it to unconditionally say core::error::Error which is an alias of std::error::Error.
You can create a wrapper error type as a workaround.
Hi! Thanks for the explanation. I totally understand the nightly Rust version constraint.
Since this change only requires swapping std::error::Error -> core::error::Error (a 1-line fix), you could implement this yourself whenever it fits your schedule. I’ll be happy to open an issue for this if needed.
No need to wait on me—I’ll step back and let you handle it however works best!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core::error::Errorhas been stable for a while. Can we merge this?