ECHOES-1408 Allow icon-less accordion child items in SidebarNavigation

[david-cho-lerat-sonarsource]

NOTE: as we stand, with the sidebar still showing a "thin band" when collapsed, allowing no icons "breaks" the appearance, but this PR is the first in a series that will get rid of the "thin band" collapsed sidebar, and this will not be shipped on its own.

Summary

• add Layout.SidebarNavigation.AccordionItem.Item for navigation rows inside sidebar accordion sections
• allow accordion child rows to omit their icon through the dedicated accordion child item API
• extract shared sidebar item logic and shared sidebar item base props
• update stories, tests, and exports for the accordion child item API

Validation

• yarn ts-check
• yarn jest src/components/layout/sidebar-navigation
• targeted ESLint on the touched sidebar navigation files
• Sonar snippet analysis on the touched sidebar navigation files

[netlify]

✅ Deploy Preview for echoes-react ready!

Name	Link
🔨 Latest commit	d2e33ac
🔍 Latest deploy log	https://app.netlify.com/projects/echoes-react/deploys/6a4645ee6e5ff8000833611e
😎 Deploy Preview	https://deploy-preview-715--echoes-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[hashicorp-vault-sonar-prod]

ECHOES-1408

[Copilot]

Pull request overview

This PR extends Layout.SidebarNavigation to support icon-less accordion child rows and refactors shared navigation-row logic into a reusable base implementation, while also adding ariaLabel support and updating stories/tests to match the new API shape.

Changes:

• Introduces SidebarNavigationAccordionChildItem (exposed as SidebarNavigation.AccordionItem.Item) to allow accordion children with optional icons.
• Refactors shared row rendering into SidebarNavigationBaseItem and centralizes shared prop/types in SidebarNavigationTypes.ts.
• Updates Storybook stories and adds/extends unit tests for the new child item + new ariaLabel coverage.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
stories/layout/sidebar-navigation/SidebarNavigationAccordionItem-stories.tsx	Updates stories to use the new SidebarNavigation.AccordionItem.Item API and demonstrates icon-less children.
stories/layout/sidebar-navigation/SidebarNavigation-stories.tsx	Migrates sidebar navigation stories to the new accordion child item API.
stories/layout/Layout-stories.tsx	Updates layout story usage to the new accordion child item API.
src/components/layout/sidebar-navigation/SidebarNavigationTypes.ts	Adds shared sidebar navigation item base prop/types.
src/components/layout/sidebar-navigation/SidebarNavigationItem.tsx	Refactors SidebarNavigationItem to reuse the new base item.
src/components/layout/sidebar-navigation/SidebarNavigationBaseItem.tsx	Adds shared implementation for sidebar navigation link rows (tooltip, active styles, icon handling).
src/components/layout/sidebar-navigation/SidebarNavigationAccordionItem.tsx	Updates accordion item props (adds ariaLabel, icon type alias, and attempted ref support).
src/components/layout/sidebar-navigation/SidebarNavigationAccordionChildItem.tsx	Adds new accordion child item component with optional icon support.
src/components/layout/sidebar-navigation/index.ts	Exports new component/types and introduces the SidebarNavigation.AccordionItem.Item namespace.
src/components/layout/sidebar-navigation/tests/SidebarNavigationItem-test.tsx	Adds tests for ariaLabel, keyboard navigation, and ref forwarding.
src/components/layout/sidebar-navigation/tests/SidebarNavigationAccordionItem-test.tsx	Updates accordion tests to use SidebarNavigationAccordionChildItem and tests icon-less children.
src/components/layout/sidebar-navigation/tests/SidebarNavigationAccordionChildItem-test.tsx	Adds comprehensive tests for the new accordion child item component.
src/components/layout/index.ts	Re-exports the new sidebar navigation types from the top-level layout module.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

[gitar-bot]

Code Review ✅ Approved

Introduces SidebarNavigation.AccordionItem.Item to support icon-less navigation child rows while unifying base component logic. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube