Skip to content

Dev 651 nodejs 20 actions are deprecated#220

Merged
martonszak merged 6 commits intomainfrom
dev-651-nodejs-20-actions-are-deprecated
Apr 16, 2026
Merged

Dev 651 nodejs 20 actions are deprecated#220
martonszak merged 6 commits intomainfrom
dev-651-nodejs-20-actions-are-deprecated

Conversation

@martonszak
Copy link
Copy Markdown
Contributor

@martonszak martonszak commented Apr 14, 2026

Overview

Required checks

Mark all tasks that were completed with a checkmark. Unrelated tasks can be left unchecked.

Required checks before asking for human review:

  • Branch is based on and up-to-date with main
  • PR has a clear title and brief description or reference to the relevant issue with details
  • All PR builders passed (linter, unit tests, e2e tests, visual regression tests)
  • Manual testing of new features or bugfixes along with affected pages or components
  • Redundant AI comments, unwanted complexity, and unintentional drifts cleaned up

Further required checks after all other major items in this list are completed:

  • No red flags from coderabbit.ai
  • Human approval

Summary by CodeRabbit

  • Chores
    • Updated automated build and testing infrastructure tools to latest versions for improved stability and security.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 14, 2026

📝 Walkthrough

Walkthrough

GitHub Actions workflow version upgrades across two CI/CD configuration files. The docker.yaml workflow updated three action versions, while tests.yaml updated five action versions across multiple jobs. No workflow logic, control flow, or behavior was modified.

Changes

Cohort / File(s) Summary
Docker Workflow
.github/workflows/docker.yaml
Updated action versions: actions/checkout (v4→v5), aws-actions/configure-aws-credentials (v4→v6), docker/build-push-action (v5→v7).
Test Workflows
.github/workflows/tests.yaml
Updated action versions across jobs: actions/checkout (v4→v5), browser-actions/setup-chrome (v1→v2), cypress-io/github-action (v6→v7), actions/upload-artifact (v4→v7).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Dependencies hop and leap so high,
From v4 to v5, we say goodbye!
Docker builds and tests now sing,
Fresh new versions on the wing!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is a template checklist without any narrative content explaining the changes or addressing the deprecated Node.js 20 actions issue mentioned in the title. Add an Overview section with a brief description of why GitHub Actions versions are being updated (e.g., addressing deprecated Node.js 20 actions) and what actions are affected. Include issue reference or link if available.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating deprecated GitHub Actions to newer versions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev-651-nodejs-20-actions-are-deprecated

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@daroczig daroczig temporarily deployed to dev-651-nodejs-20-actions-are-deprecated - sc-www PR #220 April 14, 2026 11:19 — with Render Destroyed
@martonszak martonszak marked this pull request as ready for review April 14, 2026 13:58
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/docker.yaml:
- Line 39: The workflow upgrade to docker/build-push-action@v7 introduces
breaking changes: ensure the GitHub Actions runner meets v2.327.1+ (Node 24)
before switching the uses line referencing docker/build-push-action@v7, replace
any removed env vars DOCKER_BUILD_NO_SUMMARY and
DOCKER_BUILD_EXPORT_RETENTION_DAYS with the v7 equivalents such as
DOCKER_BUILD_SUMMARY=false and the new export/retention settings, verify build
summary/export behavior (legacy export-build → buildx history export) so
downstream consumers still work, and review any custom integrations relying on
`@actions/core` or `@docker/actions-toolkit` for API/behavior changes and update
them accordingly.

In @.github/workflows/tests.yaml:
- Line 8: The actions/checkout@v5 step requires GitHub Actions runner v2.327.1+
and Node.js 24; update the workflow to ensure a compatible runner by setting a
modern runner image (e.g., runs-on: ubuntu-22.04 or windows-2022) and/or add a
guard that checks the runner version (using the github.runner.version context)
before invoking uses: actions/checkout@v5 so the job skips or fails fast on
older runners; locate the uses: actions/checkout@v5 occurrence in the workflow
and apply the change there (and mirror the same change for the other occurrences
referenced).
- Line 33: The workflow currently pins the step to actions/upload-artifact@v7
(the string "actions/upload-artifact@v7"); either revert/pin this action to a
v3-compatible tag (e.g., actions/upload-artifact@v3) to avoid Node 24/runner
requirements, or ensure all self-hosted runners are upgraded to Actions Runner
≥2.327.1 and validate ESM/optional 'archive' input usage; update every
occurrence of "actions/upload-artifact@v7" (also mentioned around the second
occurrence) accordingly so the workflow runs on your environment.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bf9c38ec-dd29-42cf-9074-248c74e8f256

📥 Commits

Reviewing files that changed from the base of the PR and between 333daf6 and 48e4894.

📒 Files selected for processing (2)
  • .github/workflows/docker.yaml
  • .github/workflows/tests.yaml

Comment thread .github/workflows/docker.yaml
Comment thread .github/workflows/tests.yaml
Comment thread .github/workflows/tests.yaml
@martonszak martonszak merged commit 56f5150 into main Apr 16, 2026
4 checks passed
@martonszak martonszak deleted the dev-651-nodejs-20-actions-are-deprecated branch April 16, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants