Skip to content

default RESP3 everywhere#3084

Merged
mgravell merged 3 commits into
v3from
marc/resp3_everywhere
May 20, 2026
Merged

default RESP3 everywhere#3084
mgravell merged 3 commits into
v3from
marc/resp3_everywhere

Conversation

@mgravell
Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread tests/StackExchange.Redis.Tests/RespProtocolTests.cs Outdated
@mgravell
Copy link
Copy Markdown
Collaborator Author

mgravell commented May 20, 2026

@philon-msft you're right about the v6 thing; I've refactored how this works - I've put the defaults back in place, and changed the logic so that it'll try RESP3 if:

  • if the protocol is set (explicitly or via the defaults-provider): that wins
  • if the default-version is >= 6, try RESP3
  • otherwise, don't
  • the default for default-version: is now 6
  • in all cases, HELLO is still needed; if disabled: nope

This seems a reasonable update to me; if the default-version is explicitly specified as something low (and the protocol is not specified): that will disable RESP3

This seems fine as a "major"

@mgravell mgravell marked this pull request as ready for review May 20, 2026 13:17
@mgravell mgravell merged commit c2fe0d2 into v3 May 20, 2026
3 of 4 checks passed
@mgravell mgravell deleted the marc/resp3_everywhere branch May 20, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants