TTS window: OK applies subtitle changes to main window, Cancel discards#12241
Merged
Conversation
The Text to speech window closed with a "Done" button that neither distinguished accept from discard nor propagated the session's subtitle changes. Review text edits triggered a separate Yes/No prompt after the window closed, and lines merged by the merge-continuation-lines step could not be applied at all - their review edits were only reported as "could not be updated" (#12093, third item of cvrle77's report). Replace Done with OK/Cancel: OK closes accepting the session, Cancel stops a running generation or - when idle - closes discarding changes, matching what Escape already did. On OK the main window now applies the changes directly instead of prompting: merged lines first (each merged paragraph replaces the run of lines it spans, matched by time codes), then 1:1 review text edits - so an edit made to a merged sentence in review now applies too, through the merged line's new time codes. Also removes the vestigial DoneOrCancelText property (set in four places, bound nowhere) and the now-unused prompt language strings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the third item of cvrle77's report in #12093: changes made in the TTS review should be applied to the main subtitle.
Before
After
Also removes the vestigial
DoneOrCancelTextview-model property (set in four places, bound nowhere) and the now-unused Yes/No prompt language strings; stale keys in existing translation JSONs are ignored by the deserializer. Docs updated.Note: if the user accepts the merge step but then cancels generation, OK still applies the merges - the merge was explicitly confirmed in its own dialog, so it is treated as an intended subtitle change even without finished audio.
🤖 Generated with Claude Code