Skip to content

TTS window: OK applies subtitle changes to main window, Cancel discards#12241

Merged
niksedk merged 1 commit into
mainfrom
fix/tts-ok-apply-changes-12093
Jul 7, 2026
Merged

TTS window: OK applies subtitle changes to main window, Cancel discards#12241
niksedk merged 1 commit into
mainfrom
fix/tts-ok-apply-changes-12093

Conversation

@niksedk

@niksedk niksedk commented Jul 7, 2026

Copy link
Copy Markdown
Member

Implements the third item of cvrle77's report in #12093: changes made in the TTS review should be applied to the main subtitle.

Before

  • The window closed with a single Done button that neither distinguished accept from discard nor propagated the session's subtitle changes.
  • Review text edits triggered a separate Yes/No prompt after the window closed - regardless of how it was closed.
  • Lines merged by the merge-continuation-lines step could not be applied at all; their review edits were only reported as "could not be updated".

After

  • Done is replaced by OK and Cancel. OK closes the window accepting the session's subtitle changes; Cancel stops a running generation, or - when idle - closes discarding the changes (exactly what Escape already did, so keyboard and buttons now match).
  • On OK the main window applies the changes directly instead of prompting, with a status-bar summary:
    1. Merged lines first - each merged paragraph replaces the run of lines it spans, matched by the time codes (start of the first line, end of the last), then lines are renumbered. If a removed row was selected, selection moves to the merged line.
    2. Review text edits second - matched 1:1 by time codes as before. Because merges apply first, an edit made to a merged sentence in review now applies too, through the merged line's new time codes.
  • Title-bar close (X) and Escape count as Cancel.

Also removes the vestigial DoneOrCancelText view-model property (set in four places, bound nowhere) and the now-unused Yes/No prompt language strings; stale keys in existing translation JSONs are ignored by the deserializer. Docs updated.

Note: if the user accepts the merge step but then cancels generation, OK still applies the merges - the merge was explicitly confirmed in its own dialog, so it is treated as an intended subtitle change even without finished audio.

🤖 Generated with Claude Code

The Text to speech window closed with a "Done" button that neither
distinguished accept from discard nor propagated the session's subtitle
changes. Review text edits triggered a separate Yes/No prompt after the
window closed, and lines merged by the merge-continuation-lines step
could not be applied at all - their review edits were only reported as
"could not be updated" (#12093, third item of cvrle77's report).

Replace Done with OK/Cancel: OK closes accepting the session, Cancel
stops a running generation or - when idle - closes discarding changes,
matching what Escape already did. On OK the main window now applies the
changes directly instead of prompting: merged lines first (each merged
paragraph replaces the run of lines it spans, matched by time codes),
then 1:1 review text edits - so an edit made to a merged sentence in
review now applies too, through the merged line's new time codes.

Also removes the vestigial DoneOrCancelText property (set in four
places, bound nowhere) and the now-unused prompt language strings.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@niksedk niksedk merged commit c281874 into main Jul 7, 2026
1 of 3 checks passed
@niksedk niksedk deleted the fix/tts-ok-apply-changes-12093 branch July 7, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant