Multiple replace: import rules directly from an SE 4 Settings.xml#12254
Merged
Conversation
…s.xml The right-click Import in Multiple Replace only offered .template/.csv in the file picker and only parsed the stand-alone SE 4 export shape (<MultipleSearchAndReplaceList>), so users migrating from SE 4 could not point it at their old Settings.xml (#12225) - the Ctrl+4 setup was the only path that read it. - Add .xml to the import file picker filter. - Detect the Settings.xml shape (<MultipleSearchAndReplaceGroups>) and route it through Se4SettingsXmlReplaceImporter (the Ctrl+4 parser), converted to the import dialog's CategoryImportExportItem shape. - Document it in docs/features/edit.md, with the default SE 4 Settings.xml locations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12225.
The right-click Import in Multiple Replace only offered
.template/.csvin the file picker and only parsed the stand-alone SE 4 export shape (<MultipleSearchAndReplaceList>), so users migrating from SE 4 could not point it at their oldSettings.xml— theCtrl+4"Set up like Subtitle Edit 4" flow was the only path that read it.Changes
.xml.<MultipleSearchAndReplaceGroups>(theSettings.xmlshape) is routed throughSe4SettingsXmlReplaceImporter— the same parserCtrl+4uses — via a new conversion to the import dialog'sCategoryImportExportItemshape. Exported SE 4 rule files (<MultipleSearchAndReplaceList>) keep going throughSe4XmlImporteras before.docs/features/edit.md), including the default SE 4Settings.xmllocations.Enum.Parseround-trip the dialog performs when building tree nodes.🤖 Generated with Claude Code