Point sync via other: restore Apply and Find text buttons (#12262)#12263
Merged
Conversation
The Avalonia "Point sync via another subtitle..." dialog was missing the Apply button and the two "Find text..." buttons present in SE 4. - Apply re-previews the synced timings in the left grid without closing, recomputing from the original timings so repeated clicks don't stack. - OK now also syncs from the original snapshot, avoiding a double-apply after Apply was used. - Find text opens the shared FindTextWindow for the main and the other subtitle and selects the matching line (reuses the VisualSync pattern). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12262
The Avalonia "Point sync via another subtitle…" dialog was missing three controls that exist in SE 4:
Changes
FindTextWindowand selects the matching line — reusing the same pattern already used by Visual Sync (FindTextLeft/FindTextRight).Testing
dotnet build src/ui/UI.csproj— succeeds, 0 warningsdotnet test tests/UI/UITests.csproj --filter FullyQualifiedName~PointSync— passes🤖 Generated with Claude Code