Fix/landing page - #215
Merged
Merged
Conversation
The public landing page's Trending section showed three tabs, but only Hackathons was ever backed by data — the other two were inert chips. Remove them and the now-unused Archive icon import.
The Trending tab bar offered Challenges and Past Events tabs that were inert chips over unfiltered data, and the Award-winning projects and Event showcase sections rendered hardcoded placeholder content with no backing data. Remove all three, along with the icons, state and helpers they were the only users of.
The "Trusted by Swiss research institutions" row rendered an empty
bordered square per institution — placeholder markup with no <img> at
all, so there were never any logos to load. Wire up the three we hold
assets for and drop Univ. of Bern, Univ. of Zurich and SOAD, which have
none.
Light and dark follow OrganizersSection: SDSC swaps to its dedicated
white asset, while ETH and EPFL ship white-on-transparent and get
inverted for the light canvas. SDSC cannot take the same treatment —
inverting its brand navy and green would misrender both.
The logos now link to the institutions, marked outgoing the way the rest
of the app marks them (target, rel, and an aria hint, since _blank alone
is not reliably announced). No ExternalLink icon: that is the convention
for text affordances, and AppFooter's equivalent logo row carries none.
Also on this page: "Contact Us" pointed at resolve('/'), bouncing the
visitor back to the page they were already on, so send it to the same
SDSC contact page AppFooter links. That needs CtaSection to mark an
off-site button outgoing, added as an opt-in `external` prop — the other
call site passes an internal href and must keep navigating in-app. And
drop the "Browse all" link, which also went nowhere but here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unneeded sections and buttons, see #213