Repository navigation
fix(charts): return notFound for invalid catalog case IDs - #1384
sentry[bot] wants to merge 1 commit into
Conversation
|
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
tanstack-com | e36a525 | Oct 15 2026, 11:26 PM |
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I verified this guard in a credential-free local app at e36a525. The reported /charts/catalog/charts/159-shadcn-line-linear.md URL and an uppercase ID both return HTTP 404. Removing the guard in the disposable fixture restores HTTP 500 for the reported URL; restoring it returns 404 again. The shared validator also agrees with the server schema on five invalid and three valid ID controls. This does not cover loading a valid catalog detail page end to end. The Cloudflare check is still failing, so I am leaving this open until that deployment gate is resolved. |
When users navigate to URLs with malformed case IDs (such as
/charts/catalog/charts/159-shadcn-line-linear.md), the regex validation ingetChartsCatalogCasethrows an unhandled validation error that surfaces to Sentry.Add
if (!isChartsCatalogCaseId(params.caseId)) throw notFound()to the$caseIdroute loader before invoking the server function, matching the pattern already used incharts.catalog.collections.$collectionId.tsx.Fixes TANSTACK-COM-5AF
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.