Skip to content

Add MacOS fix for serving DHCP IP broadcast #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShreyasZare merged 3 commits into from
Jun 27, 2026
Merged

Add MacOS fix for serving DHCP IP broadcast #1990

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2284601
Add MacOS fix for serving DHCP IP broadcast
Jun 20, 2026
9652fea
Remove setting socket options
Jun 20, 2026
cc05af8
Remove comment
Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion DnsServerCore/Dhcp/DhcpServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,14 @@ private async Task ProcessDhcpRequestAsync(DhcpMessage request, IPEndPoint remot
else
udpSocket = udpListener; //no appropriate socket found so use default socket

await udpSocket.SendToAsync(new ArraySegment<byte>(sendBuffer, 0, (int)sendBufferStream.Position), SocketFlags.DontRoute, new IPEndPoint(IPAddress.Broadcast, 68)); //no routing for broadcast
if (OperatingSystem.IsMacOS())
{
await udpSocket.SendToAsync(new ArraySegment<byte>(sendBuffer, 0, (int)sendBufferStream.Position), SocketFlags.None, new IPEndPoint(IPAddress.Broadcast, 68));
}
else
{
await udpSocket.SendToAsync(new ArraySegment<byte>(sendBuffer, 0, (int)sendBufferStream.Position), SocketFlags.DontRoute, new IPEndPoint(IPAddress.Broadcast, 68)); //no routing for broadcast
}
}
}
}
Expand Down