Repository navigation
refactor: use the helpers of aweXpect.Core - #391
Merged
Merged
Conversation
vbreuss
added this pull request to stack #389
October 10, 2026 09:36
Core provides both in aweXpect.Core.Extending, so the own copies are redundant; its Get() traces the exception and its TrimCommonWhiteSpace() ignores blank lines instead of failing on them. Only joining an expression that spans two lines into one remains in the package, so that the messages stay the same.
Capturing lambdas allocate a closure for every expectation; passing the arguments as state, as the extending guidelines recommend, avoids that, and marking every constraint lambda static lets the compiler guarantee that none captures.
vbreuss
force-pushed
the
refactor/core-helpers
branch
from
October 10, 2026 10:22
f9e441f to
0759578
Compare
|
🚀 Benchmark ResultsDetails
|
👽 Mutation ResultsaweXpect.ReflectionDetails
The final mutation score is 92.32%Coverage Thresholds: high:80 low:60 break:0 |
|
This is addressed in release v3.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package kept its own copies of helpers that aweXpect.Core offers, and allocated a closure for every constraint, which the extension guidelines advise against.
Changes
Get()andTrimCommonWhiteSpace()fromaweXpect.Core.Extendinginstead of the package's own copies; a caller expression spanning two lines is still joined into one line, and blank lines in a multi-line expression no longer break the trimmingstaticlambdas in allAddConstraintcalls