Repository navigation
fix: use "an" before vowel sounds in header and method expectations - #173
Merged
Merged
Conversation
Failure messages read "has a `Accept` header" or "has a OPTIONS method", because the article was hard-coded. It now follows the header name (reading a leading single letter such as in `X-Request-Id` by its name) and the HTTP method.
vbreuss
enabled auto-merge (squash)
October 10, 2026 06:18
vbreuss
disabled auto-merge
October 10, 2026 06:26
vbreuss
enabled auto-merge (squash)
October 10, 2026 06:27
Resolves the Sonar readability finding; string.Contains(char) is not available on netstandard2.0, so a pattern match is used instead.
|
🚀 Benchmark ResultsDetails
|
👽 Mutation ResultsaweXpect.WebDetails
The final mutation score is 93.51%Coverage Thresholds: high:80 low:60 break:0 |
|
This is addressed in release v2.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure messages read "has a
Acceptheader" or "has a OPTIONS method", because the article was hard-coded. It now follows the header name (reading a leading single letter such as inX-Request-Idby its name) and the HTTP method.