Repository navigation
fix: follow the message conventions of aweXpect - #176
Merged
Merged
Conversation
The failure messages now read like the built-in ones: a string that belongs to the subject (request URI, string content, content type, header value) is named as its member instead of being reported as the subject itself, header names and methods are formatted like every other value, the header-value texts start with the subject instead of writing their own, and the expectation texts use the plural verb when the subject is plural. The request URI expectation states that it ignores case, and a negated header value no longer reads as a double negation, because the negation belongs to the header, like for `Whose`. Setting a problem-details option a second time now throws at the call, like the options of aweXpect, instead of silently replacing the first value while the message lists both.
vbreuss
added this pull request to stack #178
October 10, 2026 08:21
|
🚀 Benchmark ResultsDetails
|
👽 Mutation ResultsaweXpect.WebDetails
The final mutation score is 93.93%Coverage Thresholds: high:80 low:60 break:0 |
|
This is addressed in release v2.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure messages now read like the built-in ones: a string that belongs to the subject (request URI, string content, content type, header value) is named as its member instead of being reported as the subject itself, header names and methods are formatted like every other value, the header-value texts start with the subject instead of writing their own, and the expectation texts use the plural verb when the subject is plural. The request URI expectation states that it ignores case, and a negated header value no longer reads as a double negation, because the negation belongs to the header, like for
Whose.Setting a problem-details option a second time now throws at the call, like the options of aweXpect, instead of silently replacing the first value while the message lists both.