Repository navigation
refactor: Use the helpers of aweXpect.Core - #177
Merged
Merged
Conversation
…ments as state The own copy of Get() duplicated the core helper without its tracing, and the capturing constraint factories allocated a closure and a delegate for every expectation.
The method belongs to the request, so reporting it as the subject ("it was GET") contradicted the other member results, and "UNC" is pronounced with a consonant sound.
vbreuss
added this pull request to stack #178
October 10, 2026 08:21
|
Test Results 19 files 19 suites 16s ⏱️ Results for commit a5bd06f. |
👽 Mutation ResultsaweXpect.WebDetails
The final mutation score is 94.00%Coverage Thresholds: high:80 low:60 break:0 |
🚀 Benchmark ResultsDetails
|
|
This is addressed in release v2.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package kept its own copy of
Get()and allocated a closure for every constraint, which the extension guidelines advise against. This also fixes two message leftovers.Changes
Get()fromaweXpect.Core.Extendinginstead of the package's own copy; the remaining internal helper class is renamed toResultContextExtensionsto avoid a name clash with core'sThatExtensionsstaticlambdasHasMethodnames the method as a member of the request ("but it had method GET" instead of "but it was GET")