docs(linux): Update linuxptp clone URL and branch for HSR/PRP PTP#735
docs(linux): Update linuxptp clone URL and branch for HSR/PRP PTP#735danish-ti wants to merge 1 commit into
Conversation
danish-ti
requested review from
StaticRocket,
VeeruPrudhvi,
cshilwant,
gehariprasath,
jeevantelukula,
praneethbajjuri and
uditkumarti
as code owners
github-actions
Bot
assigned
danish-ti,
devarsht,
gehariprasath,
praneethbajjuri,
r-vignesh,
Siddharth-Vadapalli-at-TI and
uditkumarti
Update the linuxptp repository URL from the bigeasy fork to the mda fork, and update the branch from hsr_prp_v2_plus to hsr_prp_ptp. Also remove the now-unnecessary config file patching steps. Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
| key (destination MAC for P2P delay-request messages) into the ``[global]`` | ||
| section just after the ``delay_mechanism`` key. The second command replaces the | ||
| ``[eth1]`` and ``[eth2]`` section headers with the actual interface names: | ||
|
|
There was a problem hiding this comment.
why remove all of these details . is it no longer relevant ? is there a different interface names/configs that is changed to ?
Keep the depth of documentation consistent ( only change the url part)
|
|
||
| The `linuxptp-hsr <https://git.kernel.org/pub/scm/linux/kernel/git/bigeasy/linuxptp-hsr.git>`_ | ||
| implementation on the ``hsr_prp_v2_plus`` branch supports PTP (Precision Time Protocol) | ||
| The `linuxptp <https://git.kernel.org/pub/scm/linux/kernel/git/mda/linuxptp.git>`_ |
There was a problem hiding this comment.
@danish-ti, the commit message mentions:
Update the linuxptp repository URL from the bigeasy fork to the mda fork, and update the branch from hsr_prp_v2_plus to hsr_prp_ptp. Also remove the now-unnecessary config file patching steps.
What is the reason for switching from bigeasy fork to mda fork? Is it because the config file patching can be avoided? If yes, why not contribute to bigeasy fork directly? If that's not the case, what is the reason?
There was a problem hiding this comment.
@danish-ti, additionally, linuxptp is a well known repository at:
https://github.com/richardcochran/linuxptp
which 'DOES NOT' support HSR.
So naming the mda fork as linuxptp instead of naming it linuxptp-hsr as the bigeasy fork has done may cause confusion. I believe the bigeasy fork had a valid reason for naming the repository as linuxptp-hsr instead of linuxptp (which is to distinguish it from the main repository - https://github.com/richardcochran/linuxptp and avoid confusion to users).
7 participants
Update the linuxptp repository URL from the bigeasy fork to the mda fork, and update the branch from hsr_prp_v2_plus to hsr_prp_ptp. Also remove the now-unnecessary config file patching steps.