Skip to content

[DO NOT MERGE] -- Test inline check PR comment#4374

Open
migueldalberto wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:ci-inline-check-pr-comment
Open

[DO NOT MERGE] -- Test inline check PR comment#4374
migueldalberto wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:ci-inline-check-pr-comment

Conversation

@migueldalberto

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Miguel Dalberto Pedro <miguel.pedro@precisioninno.com>
@migueldalberto migueldalberto self-assigned this Jul 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Jenkinsfile to use a feature branch ('inline-check-pr-comment') for the shared library instead of the 'main' branch. The feedback advises reverting this change to a stable branch or version tag before merging to avoid potential pipeline failures if the feature branch is modified or deleted.

Comment thread Jenkinsfile
@@ -1,4 +1,4 @@
@Library('utils@main') _
@Library('utils@inline-check-pr-comment') _

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Referencing a feature branch ('inline-check-pr-comment') for the shared library is acceptable for testing, but it should be reverted to a stable branch (such as 'main') or a specific version tag before merging. This prevents pipeline failures if the feature branch is deleted or modified in the future.

@Library('utils@main') _

@openroad-ci

openroad-ci commented Jul 21, 2026

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check.

Commit 967a3fb · Jenkins build #7 · Baseline: build

57 design(s) checked — 0 with regression(s), 0 without a baseline.
Design Variant Verdict local vs inline passed / failed / missing
asap7/aes base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/aes-block base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/aes-mbff base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/aes_lvt base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/cva6 base ✅ pass ✅ MATCH 12 / 0 / 0
asap7/ethmac base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/ethmac_lvt base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/gcd base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/gcd-ccs base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/ibex base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/jpeg base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/jpeg_lvt base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/mock-alu base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/mock-cpu base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/riscv32i base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/riscv32i-mock-sram base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/swerv_wrapper base ✅ pass ✅ MATCH 23 / 0 / 0
asap7/uart base ✅ pass ✅ MATCH 23 / 0 / 0
gf180/aes base ✅ pass ✅ MATCH 23 / 0 / 0
gf180/aes-hybrid base ✅ pass ✅ MATCH 23 / 0 / 0
gf180/ibex base ✅ pass ✅ MATCH 23 / 0 / 0
gf180/jpeg base ✅ pass ✅ MATCH 23 / 0 / 0
gf180/riscv32i base ✅ pass ✅ MATCH 23 / 0 / 0
gf180/uart-blocks base ✅ pass ✅ MATCH 23 / 0 / 0
gt2n/aes base ✅ pass ✅ MATCH 0 / 0 / 457
gt2n/gcd base ✅ pass ✅ MATCH 0 / 0 / 451
gt2n/jpeg base ✅ pass ✅ MATCH 0 / 0 / 462
ihp-sg13g2/aes base ✅ pass ✅ MATCH 23 / 0 / 0
ihp-sg13g2/gcd base ✅ pass ✅ MATCH 23 / 0 / 0
ihp-sg13g2/i2c-gpio-expander base ✅ pass ✅ MATCH 23 / 0 / 0
ihp-sg13g2/ibex base ✅ pass ✅ MATCH 23 / 0 / 0
ihp-sg13g2/jpeg base ✅ pass ✅ MATCH 23 / 0 / 0
ihp-sg13g2/riscv32i base ✅ pass ✅ MATCH 23 / 0 / 0
ihp-sg13g2/spi base ✅ pass ✅ MATCH 23 / 0 / 0
nangate45/aes base ✅ pass ✅ MATCH 23 / 0 / 0
nangate45/ariane133 base ✅ pass ✅ MATCH 23 / 0 / 0
nangate45/ariane136 base ✅ pass ✅ MATCH 23 / 0 / 0
nangate45/dynamic_node base ✅ pass ✅ MATCH 23 / 0 / 0
nangate45/gcd base ✅ pass ✅ MATCH 23 / 0 / 0
nangate45/ibex base ✅ pass ✅ MATCH 23 / 0 / 0
nangate45/jpeg base ✅ pass ✅ MATCH 23 / 0 / 0
nangate45/mempool_group base ✅ pass ✅ MATCH 12 / 0 / 0
nangate45/swerv base ✅ pass ✅ MATCH 23 / 0 / 0
nangate45/swerv_wrapper base ✅ pass ✅ MATCH 23 / 0 / 0
nangate45/tinyRocket base ✅ pass ✅ MATCH 23 / 0 / 0
sky130hd/aes base ✅ pass ✅ MATCH 23 / 0 / 0
sky130hd/chameleon base ✅ pass ✅ MATCH 23 / 0 / 0
sky130hd/gcd base ✅ pass ✅ MATCH 23 / 0 / 0
sky130hd/ibex base ✅ pass ✅ MATCH 23 / 0 / 0
sky130hd/jpeg base ✅ pass ✅ MATCH 23 / 0 / 0
sky130hd/microwatt base ✅ pass ✅ MATCH 23 / 0 / 0
sky130hd/riscv32i base ✅ pass ✅ MATCH 23 / 0 / 0
sky130hs/aes base ✅ pass ✅ MATCH 23 / 0 / 0
sky130hs/gcd base ✅ pass ✅ MATCH 23 / 0 / 0
sky130hs/ibex base ✅ pass ✅ MATCH 23 / 0 / 0
sky130hs/jpeg base ✅ pass ✅ MATCH 23 / 0 / 0
sky130hs/riscv32i base ✅ pass ✅ MATCH 23 / 0 / 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants