Simplify bant macro#10970
Merged
maliberty merged 1 commit intoJul 24, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the qt6_library macro in .bant-macros by removing the generation of UI header paths from uic_srcs in the hdrs attribute. Additionally, it updates a transitive digest in MODULE.bazel.lock. There are no review comments, and I have no feedback to provide.
While correct, it is slightly cursed in some circumstances. Disable for now (it does not make any difference in the dwyu result) Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260722-simplify-macro
branch
from
July 22, 2026 16:44
4730555 to
a2d1253
Compare
maliberty
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While correct, it is slightly cursed in some circumstances. Disable for now (it does not make any difference in the dwyu result)