Fix dependencies for //src/rsz/test:TestRepairHoldRollback#10973
Merged
jhkim-pii merged 1 commit intoJul 23, 2026
Merged
Conversation
There are some superfluous dependencies in this target. Fixed with ``` . <(etc/run-build-cleaner.sh //src/rsz/test:TestRepairHoldRollback) ``` Signed-off-by: Henner Zeller <h.zeller@acm.org>
Contributor
There was a problem hiding this comment.
Code Review
This pull request cleans up the dependencies of a test target in src/rsz/test/BUILD by removing several unused internal dependencies, such as //src/ant, //src/dpl, //src/grt, //src/stt, //src/tst, and //src/utl. There are no review comments, and I have no additional feedback to provide.
Collaborator
Author
|
With triple-verbosity, the build cleaner describes what it looks for and the successful associations of the headers for the corresponding libraries; the superfluous libraries then can be removed: These are the associations of header files used in the test and the libraries they provide. |
jhkim-pii
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some superfluous dependencies in this target. Fixed with