Skip to content

Fix dependencies for //src/rsz/test:TestRepairHoldRollback#10973

Merged
jhkim-pii merged 1 commit into
The-OpenROAD-Project:masterfrom
hzeller:feature-20260722-fix-dep-repairhold
Jul 23, 2026
Merged

Fix dependencies for //src/rsz/test:TestRepairHoldRollback#10973
jhkim-pii merged 1 commit into
The-OpenROAD-Project:masterfrom
hzeller:feature-20260722-fix-dep-repairhold

Conversation

@hzeller

@hzeller hzeller commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

There are some superfluous dependencies in this target. Fixed with

. <(etc/run-build-cleaner.sh //src/rsz/test:TestRepairHoldRollback)

There are some superfluous dependencies in this target.
Fixed with

```
. <(etc/run-build-cleaner.sh //src/rsz/test:TestRepairHoldRollback)
```

Signed-off-by: Henner Zeller <h.zeller@acm.org>
@hzeller
hzeller requested a review from a team as a code owner July 22, 2026 21:06
@hzeller
hzeller requested a review from jhkim-pii July 22, 2026 21:06

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up the dependencies of a test target in src/rsz/test/BUILD by removing several unused internal dependencies, such as //src/ant, //src/dpl, //src/grt, //src/stt, //src/tst, and //src/utl. There are no review comments, and I have no additional feedback to provide.

@hzeller

hzeller commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator Author

With triple-verbosity, the build cleaner describes what it looks for and the successful associations of the headers for the corresponding libraries; the superfluous libraries then can be removed:

etc/run-build-cleaner.sh //src/rsz/test:TestRepairHoldRollback -vvv

These are the associations of header files used in the test and the libraries they provide.

src/rsz/test/BUILD:602:14-42:[ src/rsz/test/cpp/TestRepairHoldRollback.cc include dependency check (//src/rsz/test:TestRepairHoldRollback) ]
src/rsz/test/cpp/TestRepairHoldRollback.cc:28:11-29: #include "db_sta/dbNetwork.hh"
src/rsz/test/cpp/TestRepairHoldRollback.cc:28:11-29:    ✓ //src/dbSta:dbNetwork
src/rsz/test/cpp/TestRepairHoldRollback.cc:29:11-25: #include "db_sta/dbSta.hh"
src/rsz/test/cpp/TestRepairHoldRollback.cc:29:11-25:    ✓ //src/dbSta
src/rsz/test/cpp/TestRepairHoldRollback.cc:30:11-34: #include "est/EstimateParasitics.h"
src/rsz/test/cpp/TestRepairHoldRollback.cc:30:11-34:    ✓ //src/est
src/rsz/test/cpp/TestRepairHoldRollback.cc:31:11-23: #include "gtest/gtest.h"
src/rsz/test/cpp/TestRepairHoldRollback.cc:31:11-23:    ✓ @googletest//:gtest
src/rsz/test/cpp/TestRepairHoldRollback.cc:31:11-23:    - @googletest//:gtest_for_library (avoid if possible: alias)
src/rsz/test/cpp/TestRepairHoldRollback.cc:31:11-23:    - @yaml-cpp//test/googletest-1.13.0:gtest
src/rsz/test/cpp/TestRepairHoldRollback.cc:32:11-18: #include "odb/db.h"
src/rsz/test/cpp/TestRepairHoldRollback.cc:32:11-18:    ✓ //src/odb/src/db
src/rsz/test/cpp/TestRepairHoldRollback.cc:33:11-21: #include "odb/dbSet.h"
src/rsz/test/cpp/TestRepairHoldRollback.cc:33:11-21:    ✓ //src/odb/src/db
src/rsz/test/cpp/TestRepairHoldRollback.cc:34:11-21: #include "odb/defin.h"
src/rsz/test/cpp/TestRepairHoldRollback.cc:34:11-21:    ✓ //src/odb/src/defin
src/rsz/test/cpp/TestRepairHoldRollback.cc:35:11-24: #include "rsz/Resizer.hh"
src/rsz/test/cpp/TestRepairHoldRollback.cc:35:11-24:    ✓ //src/rsz
src/rsz/test/cpp/TestRepairHoldRollback.cc:36:11-22: #include "sta/Clock.hh"
src/rsz/test/cpp/TestRepairHoldRollback.cc:36:11-22:    ✓ //src/sta:opensta_lib
src/rsz/test/cpp/TestRepairHoldRollback.cc:37:11-22: #include "sta/Graph.hh"
src/rsz/test/cpp/TestRepairHoldRollback.cc:37:11-22:    ✓ //src/sta:opensta_lib
src/rsz/test/cpp/TestRepairHoldRollback.cc:38:11-24: #include "sta/Liberty.hh"
src/rsz/test/cpp/TestRepairHoldRollback.cc:38:11-24:    ✓ //src/sta:opensta_lib
src/rsz/test/cpp/TestRepairHoldRollback.cc:39:11-23: #include "sta/MinMax.hh"
src/rsz/test/cpp/TestRepairHoldRollback.cc:39:11-23:    ✓ //src/sta:opensta_lib
src/rsz/test/cpp/TestRepairHoldRollback.cc:40:11-21: #include "sta/Mode.hh"
src/rsz/test/cpp/TestRepairHoldRollback.cc:40:11-21:    ✓ //src/sta:opensta_lib
src/rsz/test/cpp/TestRepairHoldRollback.cc:41:11-29: #include "sta/NetworkClass.hh"
src/rsz/test/cpp/TestRepairHoldRollback.cc:41:11-29:    ✓ //src/sta:opensta_lib
src/rsz/test/cpp/TestRepairHoldRollback.cc:42:11-20: #include "sta/Sdc.hh"
src/rsz/test/cpp/TestRepairHoldRollback.cc:42:11-20:    ✓ //src/sta:opensta_lib
src/rsz/test/cpp/TestRepairHoldRollback.cc:43:11-27: #include "sta/Transition.hh"
src/rsz/test/cpp/TestRepairHoldRollback.cc:43:11-27:    ✓ //src/sta:opensta_lib
src/rsz/test/cpp/TestRepairHoldRollback.cc:44:11-22: #include "sta/Units.hh"
src/rsz/test/cpp/TestRepairHoldRollback.cc:44:11-22:    ✓ //src/sta:opensta_lib
src/rsz/test/cpp/TestRepairHoldRollback.cc:45:11-33: #include "tst/IntegratedFixture.h"
src/rsz/test/cpp/TestRepairHoldRollback.cc:45:11-33:    ✓ //src/tst:integrated_fixture

@jhkim-pii
jhkim-pii merged commit 66be680 into The-OpenROAD-Project:master Jul 23, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants