odb: add support for ground-only inter-chip parasitics#10976
Conversation
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request introduces inter-chip parasitics modeling to the ODB database by adding the dbChipCapNode and dbChipRSeg classes, along with their iterators, schema definitions, serialization support, and unit tests. The review feedback focuses on improving robustness and preventing potential crashes. Specifically, it is recommended to add a direct chip_net_ reference to dbChipRSeg to avoid dangling pointer dereferences during destruction, add null checks for chip_net_ during creation of both cap nodes and r-segs, ensure early returns after logging errors in dbChipRSeg::create, and add a null check for the bump instance in dbChipCapNode::getBTerm.
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c47040398f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
Summary
These changes introduce
dbChipRSeganddbChipCapNode. With this, we'll be about to extract parasitics of the inter-chip boundaries (bumps).Out first version of 3D RCX won't take bump context into account, so we don't need
dbChipCCSegfor now.Differently from
dbRSeg,dbCapNodeanddbCCSegwhich are lists that resolve by corner index, the new objects being added here are a single value, because we'll only support single corner in our initial 3D parasitics extraction.Type of Change
Impact
None.
Verification
./etc/Build.sh).