Repository navigation
Fixes NotEquals filter for null and typed values - #34
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Ensure date-time comparisons use the serializer’s actual representation and add execution-based list-member coverage.
Review effort: Lite
Findings: None
What changed in this PR
Fixes NotEquals filtering for null, date-time, and numeric values across scalar and list-member paths.
Changes:
- Adds
IS NOT NULLhandling for null comparisons. - Applies typed comparisons and numeric casts consistently.
- Adds regression tests and changelog documentation.
| File | Review summary |
|---|---|
TychoDB/FilterBuilder.cs |
Centralizes comparison rendering. Custom date-time formats may not match serializer output for scalar and list-member comparisons. |
TychoDB.UnitTests/NotEqualsValueTests.cs |
Covers typed values, but list-member cases verify SQL rather than execution results. |
TychoDB.UnitTests/NotEqualsNullTests.cs |
Covers null and presence semantics. |
TychoDB.UnitTests/NotEqualsDateTimeTests.cs |
Covers date-time exclusions. |
CHANGELOG.md |
Documents the fixes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Equals and NotEquals sent every non-null value on a DateTime path through GetDateTimeString, which returns an empty string for anything that is not a DateTime or DateTimeOffset. NotEquals with an already formatted string then rendered <> '' and returned every row with a date, where v5.3.0 returned the right rows. The date branch is now taken only for an actual date; other values are bound as given. Adds scalar and list-member tests for a text value on a date path, the changelog notes for it and for NaN on numeric members, and dates the 5.3.0 changelog section. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Resolves the list-member NotEquals case in favor of AppendListMemberEquality, which already carries the date branch main added there, and keeps main's JSON_EACH guard. The two 5.3.1 changelog sections are combined, with main's NotEquals-date bullet folded into the entry that already covers it. Now that list-member filters no longer raise malformed JSON, adds a test that executes the list-member NotEquals cases instead of only rendering them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the behavior of the
NotEqualsfilter for various scenarios:Filter(NotEquals, x => x.Member, null)for scalar paths generatedJSON_EXTRACT(...) <> NULL, which always evaluates to false in SQL. The filter now emitsIS NOT NULL, ensuring that the "member is present" test returns the expected rows, consistent with list-member paths andEqualsfor nulls.NotEqualswithDateTime,DateTimeOffset, or numeric values could incorrectly include excluded rows.DateTimeandDateTimeOffsetvalues were bound as culture-formatted text, not the serializer's ISO format.CAST(… as NUMERIC)for comparison.These operators now share a unified type dispatch logic for both scalar and list-member paths, guaranteeing values are bound and cast correctly (e.g.,
DateTimeuses serializer format, numeric values are cast to NUMERIC), ensuring accurate exclusions.Introduces new unit tests to thoroughly cover
NotEqualsbehavior for null, date-time, and numeric values on both scalar and list-member properties.