fix: do not log successful model deploy response as error#2377
Merged
rsynek merged 1 commit intoJun 16, 2026
Conversation
DeployModelMojo called printErrorInfo() on the success branches of deploy and update, logging the platform's success response body at ERROR level even though deployment succeeded. Limit printErrorInfo() to the genuine failure branch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Cleans up Maven plugin output by avoiding printing error details when a model deployment/update succeeds.
Changes:
- Removed
printErrorInfo(response)calls from successful deploy and overwrite flows.
|
rsynek
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When deploying or updating a model via the Maven plugin,
DeployModelMojocalledprintErrorInfo(response)on the success branches. This logged the platform's success response body at[ERROR]level even though the deployment succeeded — confusing users into thinking something failed when it did not.Reported in Slack: a successful
timefold:deployprinted the full model JSON response prefixed with[ERROR]right afterBUILD SUCCESS.Fix
Removed the
printErrorInfo(response)calls from the deploy and update success branches.printErrorInfois now only invoked on the genuine failure branch (non-2xx/3xx, non-409 responses).🤖 Generated with Claude Code