Consume flat timestamp-ordered histories during replay - #882
Draft
frankmcsherry wants to merge 1 commit into
Draft
frankmcsherry wants to merge 1 commit into
frankmcsherry wants to merge 1 commit into
Conversation
frankmcsherry
marked this pull request as ready for review
September 15, 2026 12:54
frankmcsherry
marked this pull request as draft
September 15, 2026 12:54
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
History replay retains original edits plus a second timestamp/index representation, then clones timestamps/differences into the replay buffer. Store edits in descending timestamp order with prefix meets, and consume each edit into the buffer as it is replayed. This replaces the representation with +21/-34 lines in one file.
The internal
replayoperation now consumes edits; it must be preceded by reloading the history. Current cursor reduce and join callers clear/reload before replay; the join small-cross-product path reads edits before replay. This touches shared DD history machinery and is intentionally a separate draft for discussion.Validation: DD's full default suite,
cargo test --locked --offline -p differential-dataflow, passed on this independent branch: 87 regular tests and 54 doc tests, including cursor reduce/join, their oracles, and SCC. Three regular tests and six doc examples remain ignored by the suite. Timely revision: 4eb3ee09681c209ebcaeced73548a9fbf8e1c71e.Earlier isolated measurements atop #880 plus grouped pending times showed Corgi SCC startup 5.496 → 5.420 seconds (-1.4%) and ten updates 5.714 → 5.555 seconds (-2.8%); compiled SCC was essentially flat. These are three alternating pairs on Apple M4, one worker, release/LTO, 500k nodes/1M edges, ten rounds of 1,000 replacements. They are not measurements of a combined ownership/direct-evaluation bundle, and should not be added to that bundle's gains. Other cursor-heavy workloads remain useful follow-up validation.
Based directly on
master-nextat dc3733d (#880 merged); no dependency on the pending or direct-evaluation PRs.