Repository navigation
Conversation
The generateAutoThemes function was hardcoding :host for all non-theming packages. Consumer libraries that don't set cssVariablesTarget (defaulting to "root") need :root instead. Read the CSS_VARIABLES_TARGET env var (already set per-package by nps.js from options.cssVariablesTarget) to pick the correct selector.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateAutoThemeswas hardcoding:hostfor all non-theming packagesrich-text-editor) that don't setcssVariablesTargetdefault to"root"and need:rootin their auto theme CSSCSS_VARIABLES_TARGETboolean (already set per-package bynps.jsfromoptions.cssVariablesTarget ?? "root") to pick the correct selectorSelector logic after fix
cssVariablesTargettheming:rootmain/fiori"host":host"root"(default):rootTest plan
@ui5/webcomponents(main) — auto theme CSS should use:hostcssVariablesTarget— auto theme CSS should use:root