Skip to content

chore: add biome.json + apply formatter flag-day#25

Merged
dhruva-reddy merged 1 commit into
mainfrom
chore/biome-config
May 11, 2026
Merged

chore: add biome.json + apply formatter flag-day#25
dhruva-reddy merged 1 commit into
mainfrom
chore/biome-config

Conversation

@dhruva-reddy
Copy link
Copy Markdown
Contributor

Summary

  • Caught during PR chore: retire src/eval.ts and npm run eval #24 (eval.ts retirement): this repo has no formatter config, so running biome with defaults reformats files spaces→tabs. That PR had to revert biome's reformat to avoid shipping a 700-line stylistic blast.
  • Add biome.json matching the existing 2-space / double-quote / semicolon / trailing-comma convention.
  • One-shot biome format --write of the codebase so future biome runs are no-ops on a clean checkout.
  • Linter disabled in the config — biome's "recommended" ruleset finds ~63 errors in existing code, which is a separate cleanup decision.

Style choices locked in:

  • indent: 2 spaces (matches all existing files)
  • line width: 80
  • quotes: double; semicolons: always; trailing commas: all
  • arrow parens: always

Scope: chore. No behavior change, no test impact. Pure config + mechanical reformat.

Skipped pipeline stages:

  • planner / implementer split skipped — user said "if it's easy, just toss it in" (explicit skip-planning carve-out).
  • test-writer skipped — no new behavior to spec.
  • code-reviewer skipped — mechanical formatter reformat is hand-reviewable in the diff (line breaks, trailing commas, multi-line type defs); semantically identical pre/post.

Test plan

  • `npm run build` clean (tsc --noEmit, 0 errors)
  • `npm run test` — 115/115 tests pass (no regressions from the reformat)
  • `npx @biomejs/biome format .` — "No fixes applied" (config matches codebase after the flag-day reformat)

Caught during the eval.ts retirement PR: this repo has no formatter
config, so running biome with defaults reformats files spaces→tabs.
The eval-retire PR had to revert biome's default reformat to avoid
shipping a 700-line stylistic blast.

Adding a biome.json that matches the existing 2-space / double-quote
/ semicolon / trailing-comma convention, plus a one-shot
`biome format --write` of the codebase so future biome runs are
no-ops. Linter is disabled in the config (recommended ruleset finds
~63 errors in existing code — that's a separate cleanup decision).

After this PR:
- `npx @biomejs/biome format .` returns "No fixes applied"
- `npm run build` clean, all 115 tests still pass
- Any contributor running biome will get the same style without
  reformat conflicts

Style choices locked in:
- indent: 2 spaces (matches all existing files)
- line width: 80
- quotes: double, semicolons: always
- trailing commas: all
- arrow parens: always
@dhruva-reddy dhruva-reddy merged commit 9e23bce into main May 11, 2026
@dhruva-reddy dhruva-reddy deleted the chore/biome-config branch May 11, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant