Repository navigation
Speed up component rendering and eager loading - #2759
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Make rendering and boot faster using the existing benchmarks and Vernier.
What approach did you choose and why?
Share source-file reads during eager loading, avoid repeated virtual-path lookups, and reduce nested-render and default-slot lookup overhead. File reads remain uncached outside eager loading.
Anything you want to highlight for special attention from reviewers?
Three paired runs, 45 samples per scenario, Ruby 4.1-dev / Rails 8.1.4. Ratios normalize rendering against an equivalent partial, and ViewComponent boot time against the rest of boot; lower is better.
No scenario regressed.
bundle exec rake all_testsand targeted StandardRB checks passed.