fix: tolerate missing shell completion support across distros#32
Conversation
Symfony Console on bookworm only supports bash, on jammy supports no shells at all, while trixie/noble/resolute support both bash and zsh. Add || true so builds don't fail when a distro's Symfony version doesn't support the requested shell. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR modifies ChangesBuild completion generation error tolerance
🎯 1 (Trivial) | ⏱️ ~2 minutes
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
bashcompletion —completion zshexits non-zero and breaks the buildsupported shells: "") — evencompletion bashfails|| trueto both completion commands lets each distro produce what it can without failing the buildTest plan
override_dh_installwithout error🤖 Generated with Claude Code
Summary by CodeRabbit