Skip to content

fix: tolerate missing shell completion support across distros#32

Merged
Vitexus merged 1 commit into
mainfrom
fix/shell-completion-unsupported-distros
May 26, 2026
Merged

fix: tolerate missing shell completion support across distros#32
Vitexus merged 1 commit into
mainfrom
fix/shell-completion-unsupported-distros

Conversation

@Vitexus
Copy link
Copy Markdown
Member

@Vitexus Vitexus commented May 26, 2026

Summary

  • Bookworm ships Symfony Console that only supports bash completion — completion zsh exits non-zero and breaks the build
  • Jammy ships an even older version with no shell completion support at all (supported shells: "") — even completion bash fails
  • Trixie, noble, and resolute have newer Symfony with full bash+zsh support and generate completions correctly
  • Adding || true to both completion commands lets each distro produce what it can without failing the build

Test plan

  • Trigger a new Jenkins build and confirm all five distros (bookworm, trixie, jammy, noble, resolute) complete override_dh_install without error
  • Verify bash completion file is present in packages built on bookworm/trixie/noble/resolute
  • Verify zsh completion file is present in packages built on trixie/noble/resolute

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Improved build resilience by allowing shell completion generation to fail without interrupting the packaging process.

Review Change Stack

Symfony Console on bookworm only supports bash, on jammy supports
no shells at all, while trixie/noble/resolute support both bash and
zsh. Add || true so builds don't fail when a distro's Symfony version
doesn't support the requested shell.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fe66ab52-c4be-407b-ac12-a377a342480f

📥 Commits

Reviewing files that changed from the base of the PR and between d7fcb6a and c01b677.

📒 Files selected for processing (1)
  • debian/rules

📝 Walkthrough

Walkthrough

The PR modifies debian/rules to make the Bash and Zsh completion generation steps error-tolerant by appending || true to both commands. This prevents packaging build failures when completion generation returns a non-zero exit status.

Changes

Build completion generation error tolerance

Layer / File(s) Summary
Build completion generation error tolerance
debian/rules
The php /tmp/multiflexi-cli-build.php completion bash and php /tmp/multiflexi-cli-build.php completion zsh commands are modified to append || true, allowing the Debian package build to proceed even if completion generation fails.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🐰 A clever trick, so small yet mighty,
Add || true and build stays flighty,
No failures now, just smooth scrolls ahead,
Completion may falter, but builds aren't dead! 🎉

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/shell-completion-unsupported-distros

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Vitexus Vitexus merged commit ca27632 into main May 26, 2026
2 of 3 checks passed
@Vitexus Vitexus deleted the fix/shell-completion-unsupported-distros branch May 26, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant