Skip to content

feat(Activity Icons): Show activity icons in authoring and teacher tools - #2330

Open
breity wants to merge 2 commits into
developfrom
add-activity-icons-authoring-grading
Open

feat(Activity Icons): Show activity icons in authoring and teacher tools#2330
breity wants to merge 2 commits into
developfrom
add-activity-icons-authoring-grading

Conversation

@breity

@breity breity commented Jul 29, 2026

Copy link
Copy Markdown
Member

Changes

  • Add icons font names to the different activity (component) types. Icons are defined in each activity type's [Component]Info class and retrieved using ComponentInfoService. We now also retrieve component display names using ComponentInfoService across the apps.
  • Show activity icons whenever we list activity types in the authoring and teacher tools.

Test

Ensure that icons are shown along with the activity labels whenever activity types appear in the authoring and teacher tools.

@breity
breity requested a review from hirokiterashima July 29, 2026 16:53
@breity breity self-assigned this Jul 29, 2026
@breity breity added the enhancement New feature of any size or improvement (UI, performance, security) label Jul 29, 2026
@qltysh

qltysh Bot commented Jul 29, 2026

Copy link
Copy Markdown

❌ 2 blocking issues (2 total)

Tool Category Rule Count
qlty Duplication Found 35 lines of similar code in 2 locations (mass = 148) 2

name: this.getComponentTypeLabel('Match'),
icon: this.getComponentTypeIcon('Match')
}
]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 35 lines of similar code in 2 locations (mass = 148) [qlty:similar-code]

name: this.getComponentTypeLabel('Table'),
icon: this.getComponentTypeIcon('Table')
}
]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 35 lines of similar code in 2 locations (mass = 148) [qlty:similar-code]

@qltysh

qltysh Bot commented Jul 29, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (51)

RatingFile% DiffUncovered Line #s
New Coverage rating: F
src/assets/wise5/components/conceptMap/conceptMapService.ts100.0%
New Coverage rating: A
src/assets/wise5/components/graph/GraphInfo.ts100.0%
New Coverage rating: A
...ets/wise5/components/audioOscillator/audioOscillatorService.ts100.0%
New Coverage rating: A
src/assets/wise5/components/dialogGuidance/DialogGuidanceInfo.ts100.0%
New Coverage rating: A
...s/nodeGrading/filter-components/filter-components.component.ts100.0%
New Coverage rating: C
src/assets/wise5/components/discussion/discussionService.ts100.0%
New Coverage rating: A
src/assets/wise5/components/conceptMap/ConceptMapInfo.ts100.0%
New Coverage rating: D
src/assets/wise5/components/componentService.ts85.7%63
New Coverage rating: A
...s/component-type-selector/component-type-selector.component.ts100.0%
New Coverage rating: A
...nents/component-type-button/component-type-button.component.ts100.0%
New Coverage rating: A
src/assets/wise5/components/animation/AnimationInfo.ts100.0%
New Coverage rating: A
src/assets/wise5/components/html/htmlService.ts100.0%
New Coverage rating: F
src/assets/wise5/components/graph/graphService.ts100.0%
New Coverage rating: A
src/assets/wise5/components/html/HtmlInfo.ts100.0%
New Coverage rating: A
src/assets/wise5/components/label/LabelInfo.ts100.0%
New Coverage rating: F
src/assets/wise5/components/embedded/embeddedService.ts100.0%
New Coverage rating: F
src/assets/wise5/components/aiChat/aiChatService.ts100.0%
New Coverage rating: A
...assets/wise5/components/audioOscillator/AudioOscillatorInfo.ts100.0%
New Coverage rating: F
...nents/edit-component-dialog/edit-component-dialog.component.ts20.0%27-30
New Coverage rating: A
src/assets/wise5/components/aiChat/AiChatInfo.ts100.0%
New Coverage rating: F
...assets/wise5/components/discussion/teacherDiscussionService.ts100.0%
New Coverage rating: F
src/assets/wise5/components/ComponentInfo.ts0.0%3
New Coverage rating: F
.../authoringTool/node/node-authoring/node-authoring.component.ts0.0%64
New Coverage rating: A
src/assets/wise5/components/draw/DrawInfo.ts100.0%
New Coverage rating: B
...rComponents/nodeGrading/node-grading/node-grading.component.ts100.0%
New Coverage rating: A
src/assets/wise5/components/match/MatchInfo.ts100.0%
New Coverage rating: D
src/assets/wise5/components/label/labelService.ts100.0%
New Coverage rating: F
...deGrading/node-workgroup-item/node-workgroup-item.component.ts50.0%64
New Coverage rating: B
src/assets/wise5/components/draw/drawService.ts100.0%
New Coverage rating: F
...milestone-workgroup-item/milestone-workgroup-item.component.ts50.0%30
New Coverage rating: A
src/assets/wise5/components/discussion/DiscussionInfo.ts100.0%
New Coverage rating: A
src/assets/wise5/components/embedded/EmbeddedInfo.ts100.0%
New Coverage rating: A
...ssets/wise5/components/dialogGuidance/dialogGuidanceService.ts100.0%
New Coverage rating: A
src/assets/wise5/components/peerChat/PeerChatInfo.ts100.0%
New Coverage rating: B
src/assets/wise5/components/peerChat/peerChatService.ts100.0%
New Coverage rating: A
src/assets/wise5/components/match/matchService.ts100.0%
New Coverage rating: D
src/assets/wise5/components/showMyWork/showMyWorkService.ts100.0%
New Coverage rating: A
src/assets/wise5/components/openResponse/OpenResponseInfo.ts100.0%
New Coverage rating: F
src/assets/wise5/components/showGroupWork/showGroupWorkService.ts100.0%
New Coverage rating: A
src/assets/wise5/components/summary/summaryService.ts100.0%
New Coverage rating: A
src/assets/wise5/components/openResponse/openResponseService.ts100.0%
New Coverage rating: A
src/assets/wise5/components/summary/SummaryInfo.ts100.0%
New Coverage rating: A
src/assets/wise5/components/table/tableService.ts100.0%
New Coverage rating: A
src/assets/wise5/components/outsideURL/OutsideUrlInfo.ts100.0%
New Coverage rating: A
src/assets/wise5/components/showMyWork/ShowMyWorkInfo.ts100.0%
New Coverage rating: F
src/assets/wise5/services/componentTypeService.ts0.0%21-145
New Coverage rating: A
...ssets/wise5/components/multipleChoice/multipleChoiceService.ts100.0%
New Coverage rating: A
src/assets/wise5/components/multipleChoice/MultipleChoiceInfo.ts100.0%
New Coverage rating: A
src/assets/wise5/components/showGroupWork/ShowGroupWorkInfo.ts100.0%
New Coverage rating: D
src/assets/wise5/components/outsideURL/outsideURLService.ts100.0%
New Coverage rating: A
src/assets/wise5/components/table/TableInfo.ts100.0%
Total87.1%
🤖 Increase coverage with AI coding...
In the `add-activity-icons-authoring-grading` branch, add test coverage for this new code:

- `src/assets/wise5/authoringTool/components/edit-component-dialog/edit-component-dialog.component.ts` -- Line 27-30
- `src/assets/wise5/authoringTool/node/node-authoring/node-authoring.component.ts` -- Line 64
- `src/assets/wise5/classroomMonitor/classroomMonitorComponents/milestones/milestone-workgroup-item/milestone-workgroup-item.component.ts` -- Line 30
- `src/assets/wise5/classroomMonitor/classroomMonitorComponents/nodeGrading/node-workgroup-item/node-workgroup-item.component.ts` -- Line 64
- `src/assets/wise5/components/ComponentInfo.ts` -- Line 3
- `src/assets/wise5/components/componentService.ts` -- Line 63
- `src/assets/wise5/services/componentTypeService.ts` -- Line 21-145

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant