Repository navigation
CABI: trap on misaligned error-context.debug-message ptr - #740
Open
rvolosatovs wants to merge 1 commit into
Open
rvolosatovs wants to merge 1 commit into
rvolosatovs wants to merge 1 commit into
Conversation
canon_error_context_debug_message stored the debug string's (pointer, length) pair at the guest-supplied `ptr` with store_string, which writes through store_int without any alignment or bounds check. A misaligned `ptr` was thus accepted, and an out-of-bounds `ptr` silently grew the Python bytearray backing linear memory (appending at its current end) instead of trapping. Check `ptr` the same way lower_flat_values checks an out-param pointer before storing a spilled tuple: trap unless `ptr` is aligned to alignment(string) and `ptr + elem_size(string)` is within memory, then go through store, whose assertions these checks discharge. The checks run before opts.realloc is called. Assisted-by: claude:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
canon_error_context_debug_message stored the debug string's (pointer, length) pair at the guest-supplied
ptrwith store_string, which writes through store_int without any alignment or bounds check. A misalignedptrwas thus accepted, and an out-of-boundsptrsilently grew the Python bytearray backing linear memory (appending at its current end) instead of trapping.Check
ptrthe same way lower_flat_values checks an out-param pointer before storing a spilled tuple: trap unlessptris aligned to alignment(string) andptr + elem_size(string)is within memory, then go through store, whose assertions these checks discharge. The checks run before opts.realloc is called.Refs bytecodealliance/wasmtime#14626