Docs: Fix inline comment typos in build_query_vars_from_query_block() in blocks.php #11851
Docs: Fix inline comment typos in build_query_vars_from_query_block() in blocks.php #11851deepakrohillas wants to merge 66 commits into
Conversation
… add_action() `error.message` LIKE 'Uncaught exception 'Error' with message 'Call to undefined function add_action()' in /var/www/wp-content/plugins/hello.php:69%' AND `error.class` = 'Error' AND transactionUiName = '/wp-content/plugins/hello.php' 'request_uri': '/wp-content/plugins/hello.php'
…dolly_uncaught_exception Fix Uncaught exception Error with message 'Call to undefined function…
…PATH direct access to wp-includes/rss.php on line 19 https://core.trac.wordpress.org/ticket/61277
Plugin URI http to https change
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
deepakrohillas
changed the title
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
LGTM.
Curious why there are so many commits in this PR?
sabernhardt
left a comment
sabernhardt
left a comment
There was a problem hiding this comment.
Similarly, the docblocks for register_block_script_handle() and register_block_style_handle() probably should change "It detects" too.
| * Detects when a path to file was provided and optionally finds a corresponding asset | ||
| * file with details necessary to register the script module under with an | ||
| * automatically generated module ID. It returns unprocessed script module | ||
| * ID otherwise. |
There was a problem hiding this comment.
Remove "under" and wrap the lines at 80 characters:
| * Detects when a path to file was provided and optionally finds a corresponding asset | |
| * file with details necessary to register the script module under with an | |
| * automatically generated module ID. It returns unprocessed script module | |
| * ID otherwise. | |
| * Detects when a path to file was provided and optionally finds a corresponding | |
| * asset file with details necessary to register the script module with an | |
| * automatically generated module ID. It returns unprocessed script module ID | |
| * otherwise. |
4 participants
https://core.trac.wordpress.org/ticket/65259
In src/wp-includes/blocks.php, the inline comment inside build_query_vars_from_query_block() contains two errors: (1) "before hand" should be "beforehand" (compound adverb), and It detects when a path to file was provided from this "It" should be removed.
WordPress inline documentation standards, especially for DocBlocks.
In WordPress coding standards:
The description section should continue naturally and should not start with “It”.