Skip to content

Emoji: Load wp-emoji-loader as an external script module.#11858

Open
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/trac-64259
Open

Emoji: Load wp-emoji-loader as an external script module.#11858
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/trac-64259

Conversation

@itzmekhokan
Copy link
Copy Markdown

Converts the emoji detection loader from an inline script module (~3KB inlined on every page) to an external wp-emoji-loader script module, per #64259.

  • Registers and enqueues wp-emoji-loader via wp_enqueue_script_module() with fetchpriority=low and in_footer=true
  • Passes emoji settings through the script_module_data_wp-emoji-loader filter instead of a hand-printed JSON block
  • Updates emoji-loader.js to read wp-script-module-data-wp-emoji-loader (legacy wp-emoji-settings fallback retained)
  • Keeps window._wpemojiSettings for backward compatibility

Trac ticket: https://core.trac.wordpress.org/ticket/64259

@github-actions
Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props khokansardar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Register the emoji detection loader via wp_enqueue_script_module() with low fetch priority and footer placement, and pass settings through the script module data API instead of inlining ~3KB of JavaScript on every page.

Props Khokan Sardar.
Fixes #64259.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant