Repository navigation
[XRT-SMI] Update platform report - #10052
Merged
Merged
Conversation
Signed-off-by: Akshay Tondak <aktondak@amd.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
stsoe
pushed a commit
that referenced
this pull request
Oct 11, 2026
* Remove validate tests from PFs (#10040) * [XRT-SMI] Cleanup logic into specific files and prune VF specific options (#10047) * update platform report (#10052) * CR-1272937: xrt::kernel::group_id() throw on missing memory connectivity (#10028) When a kernel argument has no memory bank connectivity, group_id() returned 65535 (no_memidx encoded as 0xFFFF). Passing that value to xrt::bo() caused a cryptic std::out_of_range crash instead of an actionable error. Validate the argument index and memory group assignment in group_id() and throw xrt_core::error(EINVAL) with a descriptive message. connectivity and no_memidx are public so group_id() can use them. * CR-1272937: throw from group_id() only for buffer arguments (#10059) group_id() must still throw when a global/constant argument has no memory connectivity so xrt::bo is not given bank 0xffff. Scalar, stream, and local arguments are queried by field applications and must keep the legacy encoded invalid group. * AIESW-41600 Remove skipped validate tests for npu3 (#10062) * update list of commands for vf (#10075) * xrt-smi: gate validate hidden options, align --pmode help, report each --loop iteration (#10076) Require --advanced to parse validate hidden options (matching examine), and use the same --pmode mode list as configure for Ryzen/NPU3. Run the validate --loop iterations from the validate subcommand instead of inside TestRunner::startTest, so each iteration's result is printed and recorded in the JSON output instead of only the last one. A warning in a later iteration no longer masks an earlier failure. * Support displaying soft realtime in aie-partitions report (#10085) * [XRT-SMI] Add warning for enabled categories after disable (#10081) * Use create_dtrace_handle_elf API for creating dtrace handle (#10084) * xrt-smi: support platform device identification and aie2ps validate archive (#10093) Signed-off-by: Wendy Liang <wendy.liang@amd.com> Signed-off-by: Akshay Tondak <aktondak@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This PR updates the xrt-smi platform report to catch general exception and print NA in case the query fails.
This is required since the NPU load is not supported on strix platforms and should show N/A instead of failing.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
None
How problem was solved, alternative solutions (if any) and why they were rejected
Solved via broadening the exception handling
Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
Tested on strix platform. The report now shows NA:
Documentation impact (if any)
None