Skip to content

feat:[AH-2596]: fix for npm purl:#82

Open
abhinavcode wants to merge 1 commit into
mainfrom
AH-2596-fix
Open

feat:[AH-2596]: fix for npm purl:#82
abhinavcode wants to merge 1 commit into
mainfrom
AH-2596-fix

Conversation

@abhinavcode

@abhinavcode abhinavcode commented Feb 20, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • Fixed handling of npm scoped package names to ensure proper URL encoding and compatibility.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai

coderabbitai Bot commented Feb 20, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

The npm.go helper now properly URL-encodes "@" characters as "%40" when constructing Package URLs (PURLs) for npm scoped packages, improving handling of package names like "@scope/package-name".

Changes

Cohort / File(s) Summary
npm PURL Encoding
registry/app/helpers/pkg/npm.go
Added strings package import and modified GetPurlForArtifact to encode "@" as "%40" in package names for proper URL-encoded PURL construction.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A scoped package, once tangled in "@",
Now hops through the PURL encoded just right,
"%40" converts all the chaos away,
This rabbit approves of such clarity and light! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title mentions 'fix for npm purl' which directly relates to the changeset that fixes npm PURL encoding by replacing '@' with '%40' for scoped package names.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch AH-2596-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants