Add unit tests for admin wallet blacklist rejecting buy/sell/registration - #702
Merged
Chucks1093 merged 8 commits intoAug 23, 2026
Merged
Conversation
Adds ContractError::WalletBlacklisted, a Blacklisted(Address) DataKey, and is_blacklisted/assert_not_blacklisted helpers backing the admin wallet blacklist feature.
Covers the buy path from issue accesslayerorg#700: a blacklisted buyer must be rejected and must not mutate supply or balance state.
Covers the sell path from issue accesslayerorg#700: a blacklisted seller must be rejected and must not mutate their key balance.
Covers the registration path from issue accesslayerorg#700: a blacklisted wallet must not be able to register as a creator.
Covers the removal path from issue accesslayerorg#700: buy, sell, and registration must all succeed again once the admin lifts the block.
Covers the admin-only acceptance criterion from issue accesslayerorg#700: neither blacklist_wallet nor remove_from_blacklist may be called by a non-admin, and storage state is unchanged when rejected.
Adds a regression covering that blacklisting one wallet does not block trading for any other, unrelated wallet.
CI's format check failed because the parameter list exceeded rustfmt's line width. Verified locally with cargo fmt --check, cargo clippy -D warnings, and cargo test --workspace (all pass).
5 tasks
Member
|
Good implementation Akintewe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
creator-keys:blacklist_wallet/remove_from_blacklistadmin entrypoints, ais_wallet_blacklistedread-only view, and a newContractError::WalletBlacklistedvariant.buy_key/buy_key_with_referrer,sell_key, andregister_creatorso a blacklisted wallet is rejected withWalletBlacklistedbefore any state mutation.creator-keys/tests/wallet_blacklist.rscovering:WalletBlacklistedand leaves supply/balance unchangedWalletBlacklistedand leaves balance unchangedregister_creatorwithWalletBlacklistedand leaves the creator unregisteredblacklist_walletorremove_from_blacklistTest plan
emergency_pause.rs/admin_unauthorized.rsintegration-test patterns in this crate (try_*client calls asserted againstErr(Ok(ContractError::...))).closes #700