Skip to content

switching from IconManager to IconLoader #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adrienpessu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

switching from IconManager to IconLoader #199

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
265727c
update
adrienpessu Feb 16, 2026
3d0f309
Merge branch 'main' into chore/change_deprecated_icon_method
adrienpessu Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/kotlin/com/github/adrienpessu/sarifviewer/SarifFileType.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package com.github.adrienpessu.sarifviewer
import com.github.adrienpessu.sarifviewer.toolWindow.SarifViewerWindowFactory
import com.intellij.json.JsonFileType
import com.intellij.openapi.project.Project
import com.intellij.openapi.util.IconLoader
import com.intellij.openapi.vfs.VirtualFile
import com.intellij.openapi.wm.ToolWindowManager
import com.intellij.ui.IconManager
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IconManager is no longer used after switching to IconLoader, so this import should be removed to avoid unused-import warnings/inspections.

Suggested change
import com.intellij.ui.IconManager

Copilot uses AI. Check for mistakes.
Expand Down Expand Up @@ -36,7 +37,7 @@ object SarifFileType : JsonFileType() {
}

private fun load(path: String, cacheKey: Int, flags: Int): Icon {
return IconManager.getInstance().getIcon(path, SarifFileType::class.java)
return IconLoader.getIcon(path, SarifFileType::class.java.classLoader)
}
Comment on lines 39 to 41
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cacheKey and flags are unused in load(...), and the method is private with only one call site. Consider simplifying the signature (and updating the call) to avoid misleading future readers and to satisfy unused-parameter inspections.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator Author

@adrienpessu adrienpessu Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback


fun useNativeIcon(): Boolean = false
Expand Down
Loading