Add missing Cargo.lock files and ext/ crate for Rust QL tools test fixtures#210
Merged
data-douser merged 2 commits intomainfrom Apr 6, 2026
Merged
Conversation
…xtures Agent-Logs-Url: https://github.com/advanced-security/codeql-development-mcp-server/sessions/76f18017-7f73-4be3-831e-7a9c92163773 Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add missing Cargo.lock files and ext crate for Rust QL tools
Add missing Cargo.lock files and ext/ crate for Rust QL tools test fixtures
Apr 6, 2026
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the missing Rust Cargo artifacts required for deterministic CodeQL database extraction in the Rust QL tools test fixtures, and scaffolds the previously “models-only” ext/ fixture directory as an actual Rust crate.
Changes:
- Add minimal
Cargo.lockfiles forCallGraphFromTo,CallGraphTo, andPrintCFGtest fixtures. - Add Rust crate scaffolding for
server/ql/rust/tools/test/ext/viaCargo.toml,Cargo.lock, and an (intentionally) emptylib.rs.
Show a summary per file
| File | Description |
|---|---|
| server/ql/rust/tools/test/PrintCFG/Cargo.lock | Adds deterministic lockfile for the PrintCFG fixture crate. |
| server/ql/rust/tools/test/CallGraphTo/Cargo.lock | Adds deterministic lockfile for the CallGraphTo fixture crate. |
| server/ql/rust/tools/test/CallGraphFromTo/Cargo.lock | Adds deterministic lockfile for the CallGraphFromTo fixture crate. |
| server/ql/rust/tools/test/ext/Cargo.toml | Adds minimal crate manifest so ext/ can be used as a dependency fixture. |
| server/ql/rust/tools/test/ext/Cargo.lock | Adds deterministic lockfile for the ext/ fixture crate. |
| server/ql/rust/tools/test/ext/lib.rs | Adds an empty library source file to complete the crate scaffold. |
Copilot's findings
- Files reviewed: 1/6 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust QL tools test directories
CallGraphFromTo,CallGraphTo, andPrintCFGare missingCargo.lockfiles needed for deterministic CodeQL database extraction. Theext/directory also lacks the Rust crate scaffolding (Cargo.toml,Cargo.lock,lib.rs) to serve as a dependency fixture.Added files
Cargo.lockinCallGraphFromTo/,CallGraphTo/,PrintCFG/,ext/— minimal lock files matching the existing pattern inPrintAST/andCallGraphFrom/ext/Cargo.toml— empty library crate (edition 2021), same format as sibling test directoriesext/lib.rs— empty library source