[WIP] Refactor release workflow for modular deployment environments#46
Closed
Copilot wants to merge 2 commits intodd/update-release-artifact-upload/3from
Closed
[WIP] Refactor release workflow for modular deployment environments#46Copilot wants to merge 2 commits intodd/update-release-artifact-upload/3from
Copilot wants to merge 2 commits intodd/update-release-artifact-upload/3from
Conversation
- Modified check_versions() to compare .codeql-version against base version - Other files are compared against full version (including prerelease suffix) - This fixes the issue where --check fails with prerelease versions Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix .codeql-version comparison to use base version
This PR addresses the issue identified in PR #45 review comments where
update-release-version.sh --checkfails when validating prerelease versions.Problem
After recent changes,
.codeql-versionstores only the base version (e.g.,2.24.1) while other version-bearing files contain the full version with prerelease suffix (e.g.,2.24.1-prerelease). This caused--check 2.24.1-prereleaseto fail because it compared.codeql-versionagainst the full expected version.Solution
Modified the
check_versions()function to compare.codeql-versionagainst the base version of the expected value, while other files are compared against the full expected version.Testing
./server/scripts/update-release-version.sh --check 2.24.1-prerelease✅ passesChanges
server/scripts/update-release-version.sh- Updatedcheck_versions()function.codeql-versioncomparison💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.