Remove static .codeql-version; derive it from qlt.conf.json at runtime in copilot-setup-steps workflow

Agent-Logs-Url: https://github.com/advanced-security/codeql-sap-js/sessions/baa532ae-dce3-46f4-8f65-9200ae19135c

Co-authored-by: mbaluda <5237080+mbaluda@users.noreply.github.com>

Author: 2 people

.codeql-version

@@ -4,7 +4,7 @@ on:
   # Automatically run the setup steps when an associated workflow is changed.
   push:
     paths:
-      - '.codeql-version'
+      - 'qlt.conf.json'
       - '.github/workflows/copilot-setup-steps.yml'
       - '.node-version'
       - '**/codeql-pack.yml'
@@ -14,7 +14,7 @@ on:
       - 'extractors/cds/tools/package-lock.json'
   pull_request:
     paths:
-      - '.codeql-version'
+      - 'qlt.conf.json'
       - '.github/workflows/copilot-setup-steps.yml'
       - '.node-version'
       - '**/codeql-pack.yml'
@@ -45,6 +45,12 @@ jobs:
         working-directory: extractors/cds/tools
         run: npm ci
 
+      - name: Copilot Setup - Generate .codeql-version from qlt.conf.json
+        run: |
+          CODEQL_VERSION=$(jq -r '.CodeQLCLI' qlt.conf.json)
+          printf 'v%s\n' "${CODEQL_VERSION}" > .codeql-version
+          echo "Generated .codeql-version: $(cat .codeql-version)"
+
       - name: Copilot Setup - Setup CodeQL environment
         uses: advanced-security/codeql-development-mcp-server/.github/actions/setup-codeql-environment@main
         with:

.github/workflows/copilot-setup-steps.yml

@@ -27,7 +27,6 @@ set -euo pipefail
 ##     that reference other packs in this repository (e.g., ^X.Y.Z constraints).
 ##   - qlt.conf.json (CodeQLCLI, CodeQLStandardLibrary, CodeQLCLIBundle)
 ##     using the base version (X.Y.Z) derived by stripping any pre-release suffix.
-##   - .codeql-version (vX.Y.Z, kept in sync with qlt.conf.json CodeQLCLI)
 ##
 ## Usage:
 ##   ./scripts/update-release-version.sh <new-version>
@@ -183,24 +182,8 @@ check_versions() {
     fi
   fi
 
-  ## Also check .codeql-version consistency (must match qlt.conf.json CodeQLCLI with v prefix)
-  local codeql_version_file="${REPO_ROOT}/.codeql-version"
-  if [[ -f "${codeql_version_file}" ]]; then
-    local codeql_file_version
-    codeql_file_version=$(tr -d '[:space:]' < "${codeql_version_file}")
-    local check_base="${expected_version:-${first_version}}"
-    check_base="${check_base%%-*}"
-    local expected_codeql_version="v${check_base}"
-    if [[ "${codeql_file_version}" == "${expected_codeql_version}" ]]; then
-      echo "  ✅ .codeql-version: ${codeql_file_version}"
-    else
-      echo "  ❌ .codeql-version: ${codeql_file_version} (expected ${expected_codeql_version})"
-      all_consistent=false
-    fi
-  fi
-
   echo ""
-  echo "Checked ${file_count} version-bearing files + qlt.conf.json + .codeql-version."
+  echo "Checked ${file_count} version-bearing files + qlt.conf.json."
 
   if [[ "${all_consistent}" == true ]]; then
     if [[ -n "${expected_version}" ]]; then
@@ -274,30 +257,6 @@ update_qlt_config() {
   echo "  ✅ qlt.conf.json: CodeQLCLI -> ${base_version}"
 }
 
-## Update .codeql-version file (kept in sync with qlt.conf.json CodeQLCLI)
-## The file contains the version with a 'v' prefix, e.g. v2.25.0
-update_codeql_version_file() {
-  local new_version="$1"
-  local dry_run="${2:-false}"
-  local codeql_version_file="${REPO_ROOT}/.codeql-version"
-
-  # Derive the base version by stripping any pre-release suffix
-  local base_version="${new_version%%-*}"
-
-  if [[ ! -f "${codeql_version_file}" ]]; then
-    echo "WARNING: .codeql-version not found, skipping" >&2
-    return 0
-  fi
-
-  if [[ "${dry_run}" == true ]]; then
-    echo "  [DRY RUN] .codeql-version: -> v${base_version}"
-    return 0
-  fi
-
-  printf 'v%s\n' "${base_version}" > "${codeql_version_file}"
-  echo "  ✅ .codeql-version: -> v${base_version}"
-}
-
 ## Update internal dependency references in a qlpack.yml file
 ## e.g., advanced-security/javascript-sap-cap-models: "^2.3.0" -> "^2.4.0"
 ## e.g., advanced-security/javascript-sap-cap-models: "^2.3.0" -> "^2.4.0-alpha"
@@ -368,15 +327,14 @@ update_versions() {
     fi
   done
 
-  ## Update qlt.conf.json and .codeql-version
+  ## Update qlt.conf.json
   update_qlt_config "${new_version}" "${dry_run}"
-  update_codeql_version_file "${new_version}" "${dry_run}"
 
   echo ""
   if [[ "${dry_run}" == true ]]; then
-    echo "Would update ${updated_count} qlpack files + qlt.conf.json + .codeql-version. (Dry run — no files modified)"
+    echo "Would update ${updated_count} qlpack files + qlt.conf.json. (Dry run — no files modified)"
   else
-    echo "Updated ${updated_count} qlpack files + qlt.conf.json + .codeql-version to version ${new_version}."
+    echo "Updated ${updated_count} qlpack files + qlt.conf.json to version ${new_version}."
     echo ""
     echo "Next steps:"
     echo "  1. Run 'codeql pack upgrade' on all packs to update lock files"