Skip to content

Commit f75f848

Browse files
committed
Remove ControlTypeInHandlerModel and minor formatting
1 parent d665b93 commit f75f848

2 files changed

Lines changed: 1 addition & 29 deletions

File tree

  • javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1602,7 +1602,6 @@ module EventBus {
16021602
override DataFlow::Node getSubscriptionData() { result = this.getABoundCallbackParameter(2, 2) }
16031603
}
16041604
}
1605-
16061605
// private predicate test1(DataFlow::Node node) {
16071606
// node = ModelOutput::getATypeNode("CustomController").getInducingNode()
1608-
// }
1607+
// }

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5View.qll

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -916,30 +916,3 @@ class UI5Handler extends FunctionNode {
916916

917917
UI5Control getControl() { result = control }
918918
}
919-
920-
// /**
921-
// * Models controller references in event handlers as types
922-
// */
923-
// overlay[local?]
924-
// class ControlTypeInHandlerModel extends ModelInput::TypeModel {
925-
// override DataFlow::CallNode getASource(string type) {
926-
// // oEvent.getSource() is of the type of the Control calling the handler
927-
// // exists(UI5Handler h |
928-
// // type = h.getControl().getImportPath() and
929-
// // result.getCalleeName() = "getSource" and
930-
// // result.getReceiver().getALocalSource() = h.getParameter(0)
931-
// // )
932-
// // or
933-
// // this.getView().byId("id") is of the type of the Control with id="id"
934-
// exists(UI5Control c |
935-
// type = c.getImportPath() and
936-
// result = c.getAReference()
937-
// )
938-
// }
939-
940-
// /**
941-
// * Prevents model pruning for `ControlType`types
942-
// */
943-
// bindingset[type]
944-
// override predicate isTypeUsed(string type) { any() }
945-
// }

0 commit comments

Comments
 (0)