Add Customizations.qll files to support integration of sources into Custom CodeQL bundles#178
Merged
jeongsoolee09 merged 1 commit intomainfrom Mar 7, 2025
Merged
Conversation
These files enable the packs to be added to a CodeQL CLI bundle as customization packs, enabling them to modify out-of-the-box queries.
Contributor
|
Some thoughts:
|
Contributor
Author
|
Contributor
|
One more: Why are model packs removed from the dependencies of library packs? |
Contributor
Author
I also don't think we actually need to reference the model packs in the library pack - it's fine just to reference them in the query packs. |
Contributor
|
Questions answered, code reviewed, |
jeongsoolee09
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Customizations.qllfiles to the CAP and UI5 library packs. These files enable the packs to be added to a CodeQL CLI custom bundle as a "customization" pack, which enables us to add customRemoteFlowSourcesto out-of-the-box queries.