Add support for indexing UI5 XML views#179
Merged
jeongsoolee09 merged 1 commit intomainfrom Mar 26, 2025
Merged
Conversation
Contributor
|
Yes, with the three file patterns we're capturing all of the data formats used by our queries. There's another special file called XS Application descriptor with name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support to our JavaScript extractor hook to automatically index UI5 XML views.
Per the documentation all such views should end with the suffix
.view.xml, so we do not need to consider the contents when determining what to index.In addition to this PR, I have also opened a PR on
github/codeqlto ensure the following relevant UI5 and XSJS.jsonfiles are indexed:*.view.jsonxs-app.jsonmanifest.jsonWe document this in the
post-finalize.shhook to ensure it's clear where this happens.@jeongsoolee09 can you please confirm that after these changes we would now capture all relevant CAP, UI5 and XSJS files during extraction?