Modify cds-compilation-for-actions.test.sh script to include cap/models#211
Closed
data-douser wants to merge 2 commits intojeongsoolee09/restrict-cap-remoteflowsource-propertiesfrom
Closed
Conversation
Modifies the `cds-compilation-for-actions.test.sh` script in order to: * avoid duplicate work in compiling to `model.cds.json` per project; * ensure that `javascript/frameworks/cap/test/models/**` projects are considered in-scope for generating `model.cds.json` file per project; * avoid attempting CDS compiliation tasks for test/project directories that do not contain any `.cds` files at any supportable project path.
Migrates `*.test.sh` scripts from `extractors/cds/tools/test/` dir to `extractors/cds/tools/workflow/` dir and changes script file extensions from `.test.sh` to just `.sh`.
jeongsoolee09
requested changes
Aug 4, 2025
Contributor
jeongsoolee09
left a comment
jeongsoolee09
left a comment
There was a problem hiding this comment.
Just a minor suggestion.
data-douser
changed the base branch from
jeongsoolee09/restrict-cap-remoteflowsource-properties
to
main
data-douser
changed the base branch from
main
to
jeongsoolee09/restrict-cap-remoteflowsource-properties
Collaborator
Author
|
Closing this PR in favor of merging the equivalent set of changes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the
cds-compilation-for-actions.test.shscript in order to:model.cds.jsonper project;javascript/frameworks/cap/test/models/**projects are considered in-scope for generatingmodel.cds.jsonfile per project;.cdsfiles at any supportable project path.