Conversation
Removed LocalModelStringPropertySource class definition.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the UI5 CodeQL dataflow model to stop treating sap/ui/core/HTML (UI5HTMLControl) getContent() return values as a remote source, and adjusts the corresponding UI5 XSS test expectation to reflect the reduced/cleaned-up path output.
Changes:
- Remove
UI5HTMLControl.getContent().ReturnValuefrom thesourceModel“remote” sources list. - Update the
UI5Xssexpected output by dropping the now-eliminated self-sourced path entry involvingunsanitized.getContent().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| javascript/frameworks/ui5/ext/ui5.model.yml | Removes UI5HTMLControl.getContent() return from remote sources in the UI5 source model. |
| javascript/frameworks/ui5/test/queries/UI5Xss/xss-html-control-sanitized/UI5Xss.expected | Updates expected query output to match the revised source modeling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This PR Contributes
This pull request removes from remote sources
getContentreturn value ofUI5HTMLControl, which affects the test output for XSS built-in query as well as duplicates some custom UI5 query alerts