Potential fix for code scanning alert no. 18: Workflow does not contain permissions#179
Closed
Potential fix for code scanning alert no. 18: Workflow does not contain permissions#179
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a CodeQL security alert by adding explicit permissions to the check-dist.yml GitHub Actions workflow. The change follows the principle of least privilege by setting contents: read at the root workflow level, which is sufficient for all operations performed: checking out code, running build steps, comparing distributions, and uploading artifacts.
Key Changes
- Added
permissionsblock withcontents: readto.github/workflows/check-dist.yml
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/advanced-security/codeql-sarif-security-standard-annotator/security/code-scanning/18
To correct the issue, you should add a
permissionskey either at the root workflow level (abovejobs:) or directly in the relevant job (check-dist). Adding at the root is preferred for single-job workflows and guarantees all jobs are covered. Since this workflow only reads contents and uploads artifacts, the minimum permissions required are likelycontents: read. If artifact upload requires additional permissions, those can be added, but for the current use case,contents: readsuffices.Edit
.github/workflows/check-dist.ymlto insert the following block after the workflowname:and beforeon::No other code changes are required, as no steps shown in the workflow require write access to contents or other tokens.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.