Fix TypeScript to JavaScript mapping in CodeQL analysis#7
Merged
GeekMasher merged 3 commits intomainfrom Jun 30, 2025
Merged
Conversation
Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] BUG: Extension passes Typescript to CodeQL for query packs instead of Javascript
Fix TypeScript to JavaScript mapping in CodeQL analysis
Jun 27, 2025
Collaborator
|
Seems like a sensible fix |
GeekMasher
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The extension was incorrectly passing TypeScript files to CodeQL using
typescript-queriesinstead ofjavascript-queries, causing scans to fail. According to CodeQL documentation, TypeScript files should be analyzed using JavaScript queries.Root Cause
When languages were auto-detected from GitHub or manually configured, the original language names (like "typescript") were sometimes used instead of the properly mapped CodeQL language names (like "javascript"). This happened because the language mapping was only applied during initial auto-detection, not consistently throughout the analysis flow.
Fix
Added an additional language mapping step in
runLocalScan()to ensure all languages are consistently mapped to CodeQL languages, regardless of whether they come from:Key Changes
runLocalScan()incodeqlService.tsto always apply language mappingcodeql/javascript-queriesinstead ofcodeql/typescript-queriesBefore
After
Testing
/javascriptinstead of/typescriptrepo-javascript-hash.sarifinstead ofrepo-typescript-hash.sarifFixes #6.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.