Draft
Conversation
Agent-Logs-Url: https://github.com/advanced-security/secret-scanning-notifications/sessions/7c49507b-a4fe-4629-a17d-f04183a376ad Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
Agent-Logs-Url: https://github.com/advanced-security/secret-scanning-notifications/sessions/7c49507b-a4fe-4629-a17d-f04183a376ad Co-authored-by: felickz <1760475+felickz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unhandled exception in undici WebSocket client
Fix CVE-2026-2229: override undici to ^6.24.0
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transitive
undici@5.29.0(via@actions/core→@actions/http-client) is vulnerable to DoS through invalidserver_max_window_bitsin the WebSocket permessage-deflate extension.overridesto pinundicito^6.24.0, resolving to 6.24.1 in the lock file@actions/coreto v2+ (major version bump) since@actions/http-clientonly usesundici.ProxyAgent, which is API-compatible across v5→v6Reachability: Not reachable (high confidence)
The vulnerability is in undici's WebSocket client. This codebase makes REST calls via Octokit only — no WebSocket usage. Update satisfies scanners.
Pre-existing test failures
inputs.test.ts(3 tests) andsecretscanning.test.ts(suite) fail before and after this change — unrelated to this update.Original prompt
This section details the Dependabot vulnerability alert you should resolve
<alert_title>Undici has Unhandled Exception in WebSocket Client Due to Invalid server_max_window_bits Validation</alert_title>
<alert_description>### Impact
The undici WebSocket client is vulnerable to a denial-of-service attack due to improper validation of the
server_max_window_bitsparameter in the permessage-deflate extension. When a WebSocket client connects to a server, it automatically advertises support for permessage-deflate compression. A malicious server can respond with an out-of-rangeserver_max_window_bitsvalue (outside zlib's valid range of 8-15). When the server subsequently sends a compressed frame, the client attempts to create a zlib InflateRaw instance with the invalid windowBits value, causing a synchronous RangeError exception that is not caught, resulting in immediate process termination.The vulnerability exists because:
isValidClientWindowBits()function only validates that the value contains ASCII digits, not that it falls within the valid range 8-15createInflateRaw()call is not wrapped in a try-catch blockPatches
Has the problem been patched? What versions should users upgrade to?
Workarounds
Is there a way for users to fix or remediate the vulnerability without upgrading?</alert_description>
high
https://github.com/nodejs/undici/security/advisories/GHSA-v9p9-hfj2-hcw8 https://nvd.nist.gov/vuln/detail/CVE-2026-2229 https://hackerone.com/reports/3487486 https://cna.openjsf.org/security-advisories.html https://datatracker.ietf.org/doc/html/rfc7692 https://nodejs.org/api/zlib.html#class-zlibinflateraw https://github.com/advisories/GHSA-v9p9-hfj2-hcw8GHSA-v9p9-hfj2-hcw8, CVE-2026-2229
undici
npm
<vulnerable_versions>5.29.0</vulnerable_versions>
<patched_version>6.24.0</patched_version>
<manifest_path>package-lock.json</manifest_path>
<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known breaking changes, review the changelog or release notes, then audit the codebase for usage of affected APIs and fix any breaking changes that are found. If the package manager fails to resolve dependencies (e.g. peer dependency conflicts, incompatible engine constraints), document the error in the PR description rather than attemp...